1. 26 Apr, 2017 5 commits
  2. 24 Mar, 2017 7 commits
  3. 13 Mar, 2017 4 commits
  4. 06 Mar, 2017 1 commit
  5. 14 Feb, 2017 6 commits
  6. 31 Jan, 2017 3 commits
  7. 07 Dec, 2016 5 commits
  8. 07 Nov, 2016 9 commits
    • spiiroin's avatar
      Bump version to 0.86.0+mer7 · 43c89f3b
      spiiroin authored
    • spiiroin's avatar
      Merge branch 'mer1694_startup_and_exit' into 'master' · 6f6d4fc7
      spiiroin authored
      Fix issues related to usb-moded startup, exit and dbus usage
      See merge request !20
    • spiiroin's avatar
      [modules] Clear context pointer after dropping reference · f3a01678
      spiiroin authored
      Not explicitly initializing the pointer to null value makes the validity
      of the initial state subject to compiler/libc level implementation details.
      And not clearing the pointer after dropping the reference can lead to
      hard to debug issues if the potentially state pointer is used later on.
      Explicitly initialize the context to null value and set it back to null
      after dropping the reference.
      Signed-off-by: spiiroin's avatarSimo Piiroinen <simo.piiroinen@jollamobile.com>
    • spiiroin's avatar
      [usb-moded] Fix issues on exit path. MER#1694 · b3e2f370
      spiiroin authored
      Exiting from mainloop does not work as intended, looks like handle_exit()
      is meant to be called from main() function after mainloop is stopped. What
      happens in practice is that handle_exit() gets called from signal handler
      and it makes exit() without ever returning to main() function - which
      means some cleanup tasks are skipped.
      In general: Make cleanup tasks happen on the same logical level where
      initialization is made, re-order init/cleanup tasks according to what
      functional inter dependencies exist and add comments describing why
      things are done when they are done.
      Remove handle_exit() function and distribute work it used to do among:
      - usb_moded_stop() - exiting from mainloop
      - usb_moded_cleanup() - releasing usb-mode related state/config data
      - main() - cleaning up init steps made from main()
      To make possible ordering issues more visible, refuse to send usb-moded
      dbus signals in situations where the service name is not owned by the
      ubs-moded process.
      Signed-off-by: spiiroin's avatarSimo Piiroinen <simo.piiroinen@jollamobile.com>
    • spiiroin's avatar
      [logging] Flush output streams relevant for logging · c9055d07
      spiiroin authored
      Mixed use of syslog, stdout, stderr and differences in buffering of
      the streams causes the initial "starting up" message to end up as the
      final output in usb-moded journal when debug level logging is used
      (i.e. when freopen steps are skipped and stdout is not implicitly
      Use stderr and flush it before potentially switching to syslog logging.
      Signed-off-by: spiiroin's avatarSimo Piiroinen <simo.piiroinen@jollamobile.com>
    • spiiroin's avatar
      [logging] Use timestamps relative to usb-moded start for stderr logging · 55794637
      spiiroin authored
      Use of wall clock timestamps with microsecond accuracy makes it difficult
      to see where usb-moded is spending time during startup.
      Use timestamps that use millisecond accuracy and are relative to usb-moded
      startup time.
      Signed-off-by: spiiroin's avatarSimo Piiroinen <simo.piiroinen@jollamobile.com>
    • spiiroin's avatar
      [systemd] Use cached SystemBus connection. Fixes MER#1694 · bae87438
      spiiroin authored
      Usb-moded opens and closes a private peer-to-peer dbus connection for each
      systemd unit start/stop it needs to perform. This is relatively heavy
      operation and seems to cause problems with systemd v225 during bootup.
      Since usb-moded no longer has any reason to communicate with systemd
      before it can connect to SystemBus, we can drop the private connections
      and use cached SystemBus connection instead.
      Signed-off-by: spiiroin's avatarSimo Piiroinen <simo.piiroinen@jollamobile.com>
    • spiiroin's avatar
      [systemd] Change systemd_control_service() return value and type · 40463c7a
      spiiroin authored
      The systemd_control_service() function looks like it should return
      a boolean success/failure, but it is returning integer zero on success
      and integer one on failure - which is confusing.
      Make it return gboolean value so that success is TRUE and failure FALSE.
      Signed-off-by: spiiroin's avatarSimo Piiroinen <simo.piiroinen@jollamobile.com>
    • spiiroin's avatar
      [dsme] Make device state tracking asynchronous. MER#1694 · 4e7f9709
      spiiroin authored
      Usb-moded is making repeated blocking device state queries even when the
      component providing the service is not running.
      Use cached device state and keep it up to date fully asynchronously by
      tracking dsme service availability and state changes it signals.
      Signed-off-by: spiiroin's avatarSimo Piiroinen <simo.piiroinen@jollamobile.com>