- 24 Aug, 2018 3 commits
-
-
spiiroin authored
The mtp functionality is started roughly as follows: 1. usb-moded completes whole gadget configuration, and then 2. signals mtp mode activation on D-Bus 3. msyncd sees the mode change and loads mtp plugin 4. mtp plugin writes endpoint configuration, and then 5. scans storage ares to enumerate files exposed via mtp, but 6. does not really respond to ptp/mtp requests until storages are ready The problems are: While the above sequence has worked with with android usb, it does cause timing issues for usb enumeration and longer than expected response times from pc side mtp initiator point of view. Additionally when configfs is used, the gadget configuration can't even be completed before mtp daemon gets a chance to write configuration data to the control endpoint. To remedy the situation the following changes are made: 1. buteo-mtp-qt5-sync-plugin package is removed from the system -> mtp functionality is no longer handled by msyncd process 2. mtp daemon is made to enumerate storage content before writing config data to control endpoint -> when usb enumeration is possible, mtp daemon is already ready to handle commands from initiator 3. usb-moded explicitly starts/stops mtp daemon when it is about to activate/deactivate mtp_mode -> usb stays configured in charging mode until it is ready to handle mtp This patch handles step (3). Step (2) is in buteo-mtp-qt5 >= 0.5.0, and (1) needs to be fixed in device specific package configuration. Signed-off-by:
Simo Piiroinen <simo.piiroinen@jollamobile.com>
-
spiiroin authored
The "buteo-mtp" package name is probably old qt4 package that does not exist anymore. Signed-off-by:
Simo Piiroinen <simo.piiroinen@jollamobile.com>
-
spiiroin authored
Add custom Makefile for faster smoke-test rebuilds without spending time in configure, autotools, document generation and/or rolling rpm packages. Add multiple include protection to all header files. Move function prototypes away from header files that included in the development package. Mass rename functions to have a prefix giving context for the function. For the most part the prefix is derived from the name of the compilation module containing the function. Mass normalize indentation to four spaces in all source files. Augment author lists on each source file based on git committers. Remove "inline" attributes from not-really-inlineable functions. Remove .gitignore. Remove unused modules-android.c source file. Define _GNU_SOURCE for whole build rather than in individual files. Fix resource leaks here and there. Try to avoid hard-coding android usb paths. Add configfs backend for usb cadget configuration. Probe supported backends (configfs, android usb, or kmod) on usb-moded startup and make them mutually exclusive with each other. Allow configfs and android usb control structures some time to show up if usb-moded is started during device bootup. Refactor udev event listener to utilize a state machine. Simplifies book keeping and makes pc/charger detection heuristics easier to control. Refactor mode selection to utilize three interconnected mini state machines. Allows separating logically wanted mode from mode programmed to usb and mode exposed over D-Bus. Signed-off-by:
Simo Piiroinen <simo.piiroinen@jollamobile.com>
-
- 06 Jun, 2018 1 commit
-
-
spiiroin authored
-
- 04 Apr, 2018 1 commit
-
-
spiiroin authored
-
- 29 Mar, 2018 2 commits
-
-
spiiroin authored
There were non-unique dsme message type identifiers: 0x00000320 = SET_THERMAL_STATUS = BATTERY_EMPTY_IND 0x00000506 = PROCESSWD_PING = PROCESSWD_PONG Replace custom get-message-type-name functions with common functionality made available from libdsme. Signed-off-by:
Simo Piiroinen <simo.piiroinen@jollamobile.com>
-
spiiroin authored
-
- 14 Mar, 2018 1 commit
-
-
spiiroin authored
-
- 04 Dec, 2017 1 commit
-
-
spiiroin authored
-
- 15 Nov, 2017 1 commit
-
-
spiiroin authored
-
- 23 Aug, 2017 2 commits
-
-
Andrew den Exter authored
-
Andrew den Exter authored
-
- 18 Aug, 2017 1 commit
-
-
spiiroin authored
-
- 05 May, 2017 1 commit
-
-
spiiroin authored
-
- 26 Apr, 2017 3 commits
-
-
spiiroin authored
-
spiiroin authored
In addition to ensuring that usb-moded gets restarted in case it gets stuck, the process watchdog ping-pong allows scheduling of maintenance tasks at times when system is going to be active anyway. Signed-off-by:
Simo Piiroinen <simo.piiroinen@jollamobile.com>
-
spiiroin authored
The systemd development packages have changed and there are build time warnings like: sd_notify was moved to libsystemd. Do not use libsystemd-daemon. Use libsystemd as instructed. Signed-off-by:
Simo Piiroinen <simo.piiroinen@jollamobile.com>
-
- 24 Mar, 2017 2 commits
-
-
spiiroin authored
-
spiiroin authored
When doing code tweaking and manual builds with mb script, unconditionally running autogen and configure leads to unnecessary full rebuilds every time. Skip autogen and configure steps if they have already been done (based on the existence of Makefile). Signed-off-by:
Simo Piiroinen <simo.piiroinen@jollamobile.com>
-
- 13 Mar, 2017 1 commit
-
-
spiiroin authored
-
- 14 Feb, 2017 1 commit
-
-
spiiroin authored
-
- 31 Jan, 2017 1 commit
-
-
spiiroin authored
-
- 07 Dec, 2016 4 commits
-
-
Lourens-Rich authored
-
spiiroin authored
Forgot to add bug ref to commit, so 0.86.0+mer8 got rejected by ci-bot. Make a dummy version bump and add bug ref to make ci-bot happy. [ssu] Use ssusysinfo instead of SSU D-Bus interface. Fixes JB#36841
-
spiiroin authored
-
spiiroin authored
During bootup usb-moded needs device name / model information before the system has reached a point where SSU daemon can be started. This can cause systemd deadlocks and/or timeouts as usb-moded waits for SSU daemon and the rest of the bootup is blocked until usb-moded reaches ready state. Use ssu-sysinfo C-library that can provide the device details required by usb-moded without using any IPC mechanisms. Signed-off-by:
Simo Piiroinen <simo.piiroinen@jollamobile.com>
-
- 07 Nov, 2016 1 commit
-
-
spiiroin authored
-
- 03 Nov, 2016 2 commits
- 02 Nov, 2016 1 commit
-
-
phdeswer authored
Signed-off-by:
Philippe De Swert <philippedeswert@gmail.com>
-
- 18 Oct, 2016 3 commits
-
-
spiiroin authored
-
spiiroin authored
Whether and what kind of diagnostic mode is supported varies from one device to another. Having usb-moded itself depend on diagnostic mode configuration package causes unnecessary / potentially altogether wrong data to get installed on all devices. Remove dependencies from main usb-moded package to diagnostic mode configuration package. Signed-off-by:
Simo Piiroinen <simo.piiroinen@jollamobile.com>
-
spiiroin authored
-
- 05 Oct, 2016 1 commit
-
-
spiiroin authored
-
- 04 Oct, 2016 1 commit
-
-
spiiroin authored
Existing configuration files do not cover case where android kernel is used to implement just mtp functionality using ffs based userspace code - mtp_mode-android uses "mtp" instead of "ffs" and pc_suite-android activates both mtp and obex support. Add mtp_mode-android-ffs.ini that is identical with pc_suite-android.ini except for the mode name which is "mtp" instead of "pc_suite".
-
- 07 Jul, 2016 1 commit
-
-
spiiroin authored
-
- 11 May, 2016 1 commit
-
-
spiiroin authored
Maintaining usb manufacturer and product name configurations for multiple devices is cumbersome and time consuming. It also duplicates effort that is needed for ssu configuration anyway. When possible, override usb-moded manufacturer and product name configuration by using data provided by ssu D-Bus service. The feature is optional and needs to be enabled at usb-moded build time via "--enable-mer-ssu" configure option. Signed-off-by:
Simo Piiroinen <simo.piiroinen@jollamobile.com>
-
- 13 Oct, 2015 1 commit
-
-
Philippe De Swert authored
Signed-off-by:
Philippe De Swert <philippe.deswert@jollamobile.com>
-
- 12 Oct, 2015 1 commit
-
-
Philippe De Swert authored
Signed-off-by:
Philippe De Swert <philippe.deswert@jollamobile.com>
-
- 05 Oct, 2015 1 commit
-
-
Philippe De Swert authored
Diag mode has become a bit more complicated, so adding support for the new interfaces. Signed-off-by:
Philippe De Swert <philippe.deswert@jollamobile.com>
-