1. 14 Nov, 2017 1 commit
  2. 17 Aug, 2017 3 commits
    • spiiroin's avatar
      [modesetting] Write dummy value to clear ffs function list. Fixes JB#39402 · e7536ebc
      spiiroin authored
      It seems that kernels in many if not all devices ignore writing of empty
      string to ffs function control file - the function list is left as it were
      and this can cause subtle issues on the next cable connect. On the other
      hand writing a non-existing "function" will clear the function list, but
      causes write error to be reported.
      
      Treat attempts to clear function list as a special case so that non-empty
      string gets written and the resulting write error is ignored under normal
      logging verbosity.
      Signed-off-by: spiiroin's avatarSimo Piiroinen <simo.piiroinen@jollamobile.com>
      e7536ebc
    • spiiroin's avatar
      [debug] Do diagnostic logging for each D-Bus signal broadcast · 3350e0b6
      spiiroin authored
      When debugging order and timing of issues related to several processes
      it is handy to have signals emitted by usb-moded in the journal along
      with the other related logging.
      Signed-off-by: spiiroin's avatarSimo Piiroinen <simo.piiroinen@jollamobile.com>
      3350e0b6
    • spiiroin's avatar
      [debug] Optionally include file/line/function info when logging to stderr · 3420f50a
      spiiroin authored
      When debugging usb-moded it is time consuming to find where the
      various debug messages originate from.
      
      When logging to stderr, prefix the messages with source code
      position info similar as gcc uses for reporting compilation
      issues. This allows browsing usb-moded code with jump to the
      next error functionality available in many text editors.
      
      Since the amount of information passed to logging functions
      is significantly increased, check whether the message would
      be emitted or not before evaluating formatting parameters etc.
      
      Also make variables relating to logging level, type, etc
      available only via accessor functions.
      Signed-off-by: spiiroin's avatarSimo Piiroinen <simo.piiroinen@jollamobile.com>
      3420f50a
  3. 11 Aug, 2017 1 commit
  4. 26 Apr, 2017 8 commits
  5. 24 Mar, 2017 3 commits
  6. 13 Mar, 2017 2 commits
    • spiiroin's avatar
      [doc] Document undocumented structures · 1e3378f6
      spiiroin authored
      Undocumented structures cause warnings during documentation generation.
      
      Add missing doxygen documentation comments for structures.
      Signed-off-by: spiiroin's avatarSimo Piiroinen <simo.piiroinen@jollamobile.com>
      1e3378f6
    • spiiroin's avatar
      [usb-moded] Use MEEGOLOCK features only when enabled. Fixes MER#1765 · 04e3a753
      spiiroin authored
      The is_in_user_state() is used unconditionally, but it is available only
      when --enable-meegodevlock option has been passed to configure. Also,
      the related "usb_moded-dsme.h" is included both unconditionally and from
      withing a #ifdef MEEGOLOCK block - which hides the configuration problem
      until build proceeds to linking phase.
      
      Make the call is_in_user_state() only if MEEGOLOCK is defined.
      
      Remove the extraneous "usb_moded-dsme.h" include to make such errors
      visible already in compilation stage due to missing prototypes.
      
      Also, make sure the "usb_moded-dsme.h" can't be included without
      warnings unless MEEGOLOCK is defined.
      Signed-off-by: spiiroin's avatarSimo Piiroinen <simo.piiroinen@jollamobile.com>
      04e3a753
  7. 14 Feb, 2017 3 commits
  8. 31 Jan, 2017 1 commit
  9. 07 Dec, 2016 1 commit
    • spiiroin's avatar
      [ssu] Use ssusysinfo instead of SSU D-Bus interface · 536e0e4f
      spiiroin authored
      During bootup usb-moded needs device name / model information before
      the system has reached a point where SSU daemon can be started. This
      can cause systemd deadlocks and/or timeouts as usb-moded waits for SSU
      daemon and the rest of the bootup is blocked until usb-moded reaches
      ready state.
      
      Use ssu-sysinfo C-library that can provide the device details required
      by usb-moded without using any IPC mechanisms.
      Signed-off-by: spiiroin's avatarSimo Piiroinen <simo.piiroinen@jollamobile.com>
      536e0e4f
  10. 07 Nov, 2016 13 commits
  11. 03 Nov, 2016 1 commit
  12. 02 Nov, 2016 1 commit
  13. 18 Oct, 2016 2 commits