Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
[dbus] Deal with NULL strings on D-Bus signal broadcast attempts
Corrupted settings, empty lists and other hiccups can lead to usb-moded attempting to send D-Bus signal with NULL strings - which either leads to omitting signal sending when checked / crashing when not checked. To avoid crashing, make umdbus_send_signal_ex() send empty string when signal with null content is given, and add sufficient checks / diagnostic logging to umdbus_send_config_signal(). Remove null checks from common_send_hidden_modes_signal() and common_send_whitelisted_modes_signal() so that NULL set gets equated with empty set and signal broadcasting is never skipped. Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>
- Loading branch information
Showing
2 changed files
with
39 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters