Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'jb50332_multiuser_mtp' into 'master'
Keep mtp device accessible by the current user See merge request mer-core/usb-moded!63
- Loading branch information
Showing
2 changed files
with
143 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c6bb1a0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please clarify, what is the purpose of this change? I'm asking because there existed systemd mount point called
dev-mtp.mount
(from project buteo-mtp). This mountpoint was removed only in this commit, but at the time of current commit it was not. In some cases usb-moded's attempt to mount mtp device and systemd mountpoint had conflict which led to mtp module crash until device reboot.c6bb1a0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Short version: the unit file was included in wrong package (buteo-mtp). Then, when the unit was made redundant by changes done in usb mode activation side, it went unnoticed until it started causing issues -> eventually the mount unit was removed.
Some more details that are not visible in merge commits can be found in individual commits: f691d8b and sailfishos/buteo-mtp@b68b324