Skip to content

Commit

Permalink
Merge pull request #41 from nemomobile/netmask
Browse files Browse the repository at this point in the history 
[network] Add netmask handling. Fixes: JB#31127
  • Loading branch information
@philippedeswert
philippedeswert committed Aug 3, 2015
2 parents c02b3b1 + e642cef commit 6599ef5
Show file tree
Hide file tree
Showing 4 changed files with 72 additions and 60 deletions.
1 change: 0 additions & 1 deletion src/usb_moded-config-private.h
View file
Expand Up @@ -27,4 +27,3 @@
char * get_mode_setting(void);
set_config_result_t set_mode_setting(const char *mode);
set_config_result_t set_network_setting(const char *config, const char *setting);
char *get_network_setting(const char *config);
43 changes: 36 additions & 7 deletions src/usb_moded-config.c
View file
Expand Up @@ -121,7 +121,7 @@ char * get_trigger_value(void)
return(get_conf_string(TRIGGER_ENTRY, TRIGGER_PROPERTY_VALUE_KEY));
}

char * get_network_ip(void)
static char * get_network_ip(void)
{
char * ip = get_kcmdline_string(NETWORK_IP_KEY);
if (ip != NULL)
Expand All @@ -131,12 +131,12 @@ char * get_network_ip(void)
return(get_conf_string(NETWORK_ENTRY, NETWORK_IP_KEY));
}

char * get_network_interface(void)
static char * get_network_interface(void)
{
return(get_conf_string(NETWORK_ENTRY, NETWORK_INTERFACE_KEY));
}

char * get_network_gateway(void)
static char * get_network_gateway(void)
{
char * gw = get_kcmdline_string(NETWORK_GATEWAY_KEY);
if (gw != NULL)
Expand All @@ -145,7 +145,16 @@ char * get_network_gateway(void)
return(get_conf_string(NETWORK_ENTRY, NETWORK_GATEWAY_KEY));
}

char * get_network_nat_interface(void)
static char * get_network_netmask(void)
{
char * netmask = get_kcmdline_string(NETWORK_NETMASK_KEY);
if (netmask != NULL)
return(netmask);

return(get_conf_string(NETWORK_ENTRY, NETWORK_NETMASK_KEY));
}

static char * get_network_nat_interface(void)
{
return(get_conf_string(NETWORK_ENTRY, NETWORK_NAT_INTERFACE_KEY));
}
Expand Down Expand Up @@ -312,6 +321,11 @@ static char * get_kcmdline_string(const char *entry)
log_debug("Command line gateway = %s\n", ret);
}
}
if(!strcmp(entry, NETWORK_NETMASK_KEY))
{
ret = g_strdup(network_tokens[3]);
log_debug("Command line netmask = %s\n", ret);
}
}
}
g_strfreev(arg_tokens);
Expand Down Expand Up @@ -460,6 +474,15 @@ char * get_network_setting(const char *config)
}
else if(!strcmp(config, NETWORK_INTERFACE_KEY))
{

/* check main configuration before using
the information from the specific mode */
ret = get_network_interface();

if(ret)
goto end;
/* no interface override specified, let's use the one
from the mode config */
data = get_usb_mode_data();
if(data)
{
Expand All @@ -469,12 +492,18 @@ char * get_network_setting(const char *config)
goto end;
}
}
ret = get_network_interface();
if(!ret)
ret = strdup("usb0");
ret = strdup("usb0");
}
else if(!strcmp(config, NETWORK_GATEWAY_KEY))
return(get_network_gateway());
else if(!strcmp(config, NETWORK_NETMASK_KEY))
{
ret = get_network_netmask();
if(!ret)
ret = strdup("255.255.255.0");
}
else if(!strcmp(config, NETWORK_NAT_INTERFACE_KEY))
return(get_network_nat_interface());
else
/* no matching keys, return error */
return(NULL);
Expand Down
6 changes: 2 additions & 4 deletions src/usb_moded-config.h
View file
Expand Up @@ -50,6 +50,7 @@
#define NETWORK_INTERFACE_KEY "interface"
#define NETWORK_GATEWAY_KEY "gateway"
#define NETWORK_NAT_INTERFACE_KEY "nat_interface"
#define NETWORK_NETMASK_KEY "netmask"
#define NO_ROAMING_KEY "noroaming"
#define ANDROID_ENTRY "android"
#define ANDROID_MANUFACTURER_KEY "iManufacturer"
Expand All @@ -70,10 +71,7 @@ char * get_trigger_mode(void);
char * get_trigger_property(void);
char * get_trigger_value(void);

char * get_network_ip(void);
char * get_network_interface(void);
char * get_network_gateway(void);
char * get_network_nat_interface(void);
char * get_network_setting(const char *config);

char * get_android_manufacturer(void);
char * get_android_vendor_id(void);
Expand Down
82 changes: 34 additions & 48 deletions src/usb_moded-network.c
View file
Expand Up @@ -95,26 +95,13 @@ static char* get_interface(struct mode_list_elem *data)
char *interface = NULL;
int check = 0;

/* check main configuration before using
the information from the specific mode */
interface = (char *)get_network_interface();
/* no interface override specified, let's use the one
from the mode config */
if(data && !interface)
{
if(data->network_interface)
{
interface = strdup(data->network_interface);
}
}

if(interface != NULL)
check = check_interface(interface);
interface = get_network_setting(NETWORK_INTERFACE_KEY);
check = check_interface(interface);

if(interface == NULL || check != 0)
if(check != 0)
{
if(interface != NULL)
free((char *)interface);
free(interface);
/* no known interface configured and existing, falling back to usb0 */
interface = malloc(sizeof(default_interface)*sizeof(char));
strncpy(interface, default_interface, sizeof(default_interface));
Expand All @@ -124,6 +111,7 @@ static char* get_interface(struct mode_list_elem *data)
if(check)
{
log_warning("Configured interface is incorrect, nor does usb0 exists. Check your config!\n");
free(interface);
return(0);
}

Expand All @@ -143,7 +131,7 @@ static int set_usb_ip_forward(struct mode_list_elem *data, struct ipforward_data
interface = get_interface(data);
if(interface == NULL)
return(1);
nat_interface = get_network_nat_interface();
nat_interface = get_network_setting(NETWORK_NAT_INTERFACE_KEY);
if((nat_interface == NULL) && (ipforward->nat_interface != NULL))
nat_interface = strdup(ipforward->nat_interface);
else
Expand All @@ -153,7 +141,8 @@ static int set_usb_ip_forward(struct mode_list_elem *data, struct ipforward_data
/* in case the cellular did not come up we want to make sure wifi gets restored */
connman_reset_state();
#endif
free((char *)interface);
free(interface);
free(nat_interface);
return(1);
}
write_to_file("/proc/sys/net/ipv4/ip_forward", "1");
Expand Down Expand Up @@ -323,7 +312,7 @@ static int checklink(void)
static int write_udhcpd_conf(struct ipforward_data *ipforward, struct mode_list_elem *data)
{
FILE *conffile;
char *ip, *interface;
char *ip, *interface, *netmask;
char *ipstart, *ipend;
int dot = 0, i = 0, test;
struct stat st;
Expand All @@ -339,14 +328,12 @@ static int write_udhcpd_conf(struct ipforward_data *ipforward, struct mode_list_

interface = get_interface(data);
if(interface == NULL)
return(1);

/* generate start and end ip based on the setting */
ip = get_network_ip();
if(ip == NULL)
{
ip = strdup("192.168.2.15");
fclose(conffile);
return(1);
}
/* generate start and end ip based on the setting */
ip = get_network_setting(NETWORK_IP_KEY);
ipstart = malloc(sizeof(char)*15);
ipend = malloc(sizeof(char)*15);
while(i < 15)
Expand All @@ -369,11 +356,13 @@ static int write_udhcpd_conf(struct ipforward_data *ipforward, struct mode_list_
strcat(ipstart,"1");
strcat(ipend, "15");

netmask = get_network_setting(NETWORK_NETMASK_KEY);

/* print all data in the file */
fprintf(conffile, "start\t%s\n", ipstart);
fprintf(conffile, "end\t%s\n", ipend);
fprintf(conffile, "interface\t%s\n", interface);
fprintf(conffile, "option\tsubnet\t255.255.255.0\n");
fprintf(conffile, "option\tsubnet\t%s\n", netmask);
fprintf(conffile, "option\tlease\t3600\n");

if(ipforward != NULL)
Expand All @@ -391,6 +380,7 @@ static int write_udhcpd_conf(struct ipforward_data *ipforward, struct mode_list_
free(ipend);
free(ip);
free(interface);
free(netmask);
fclose(conffile);

/* check if it is a symlink, if not remove and link, create the link if missing */
Expand Down Expand Up @@ -1029,9 +1019,7 @@ int usb_network_up(struct mode_list_elem *data)
dbus_message_iter_close_container(&dict, &dict_entry);

log_debug("Set ip\n");
ip = get_network_ip();
if(ip == NULL)
ip = strdup("192.168.2.15");
ip = get_network_settings(NETWORK_IP_KEY);
dbus_message_iter_open_container(&dict, DBUS_TYPE_DICT_ENTRY, NULL, &dict_entry);
append_variant(&dict_entry, "Address", DBUS_TYPE_STRING, ip);
dbus_message_iter_close_container(&dict, &dict_entry);
Expand All @@ -1042,7 +1030,7 @@ int usb_network_up(struct mode_list_elem *data)
dbus_message_iter_close_container(&dict, &dict_entry);

log_debug("set gateway\n");
gateway = get_network_gateway();
gateway = get_network_setting(NETWORK_GATEWAY_KEY);
if(gateway)
{
dbus_message_iter_open_container(&dict, DBUS_TYPE_DICT_ENTRY, NULL, &dict_entry);
Expand Down Expand Up @@ -1074,22 +1062,20 @@ int usb_network_up(struct mode_list_elem *data)

#else
char command[128];
const char *interface;
char *interface;
char *netmask;

interface = get_interface(data);
ip = get_network_ip();
gateway = get_network_gateway();

if(interface == NULL)
return(1);

if(ip == NULL)
{
sprintf(command,"ifconfig %s 192.168.2.15", interface);
system(command);
goto clean;
}
else if(!strcmp(ip, "dhcp"))
/* interface found, so we can get all the rest */
ip = get_network_setting(NETWORK_IP_KEY);
gateway = get_network_setting(NETWORK_GATEWAY_KEY);
netmask = get_network_setting(NETWORK_NETMASK_KEY);

if(!strcmp(ip, "dhcp"))
{
sprintf(command, "dhclient -d %s\n", interface);
ret = system(command);
Expand All @@ -1102,7 +1088,7 @@ int usb_network_up(struct mode_list_elem *data)
}
else
{
sprintf(command, "ifconfig %s %s\n", interface, ip);
sprintf(command, "ifconfig %s %s %s\n", interface, ip, netmask);
system(command);
}

Expand All @@ -1113,10 +1099,10 @@ int usb_network_up(struct mode_list_elem *data)
system(command);
}

clean:
free((char *)interface);
free((char *)gateway);
free((char *)ip);
free(interface);
free(gateway);
free(ip);
free(netmask);

return(0);
#endif /* CONNMAN */
Expand Down Expand Up @@ -1174,7 +1160,7 @@ int usb_network_down(struct mode_list_elem *data)

return(ret);
#else
const char *interface;
char *interface;
char command[128];

interface = get_interface(data);
Expand All @@ -1188,7 +1174,7 @@ int usb_network_down(struct mode_list_elem *data)
if(data->nat)
clean_usb_ip_forward();

free((char *)interface);
free(interface);

return(0);
#endif /* CONNMAN_IS_EVER_FIXED_FOR_USB */
Expand Down

0 comments on commit 6599ef5

Please sign in to comment.