From 6093bf8558fe49d51bb981f4ab0c10dda75fd742 Mon Sep 17 00:00:00 2001 From: Jussi Laakkonen Date: Fri, 10 May 2019 12:20:00 +0300 Subject: [PATCH] [usb-moded] Proper use of ifconfig command. Contributes to JB#45772 Use 'ifconfig netmask ' format when calling ifconfig from usb-moded. This is the proper use according to ifconfig manual pages. When adding a netmask, keyword 'netmask' is instructed to be used. --- scripts/set_usb_mode.sh | 2 +- src/usb_moded-network.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/set_usb_mode.sh b/scripts/set_usb_mode.sh index 25e35db..35a2fe8 100755 --- a/scripts/set_usb_mode.sh +++ b/scripts/set_usb_mode.sh @@ -132,7 +132,7 @@ rndis_down() { rndis_up() { log_debug "Enable rndis interface" - ifconfig rndis0 192.168.2.15 255.255.255.0 2> /dev/null || : + ifconfig rndis0 192.168.2.15 netmask 255.255.255.0 2> /dev/null || : } udhcpd_configure() { diff --git a/src/usb_moded-network.c b/src/usb_moded-network.c index b686f2a..1175b1d 100644 --- a/src/usb_moded-network.c +++ b/src/usb_moded-network.c @@ -1192,7 +1192,7 @@ int network_up(const modedata_t *data) } else { - sprintf(command, "ifconfig %s %s %s\n", interface, ip, netmask); + sprintf(command, "ifconfig %s %s netmask %s\n", interface, ip, netmask); common_system(command); }