[usb_moded] Use accessor functions for diag mode toggle

Makes it easier to differentiate between value use and value modify. Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>
sailfishos · Sep 5, 2018 · 545aa27 · 545aa27
1 parent 478ac65
commit 545aa27
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 9 deletions.
diff --git a/src/usb_moded-common.c b/src/usb_moded-common.c
@@ -454,7 +454,7 @@ gchar *common_get_mode_list(mode_list_type_t type)
 
     modelist_str = g_string_new(NULL);
 
-    if(!usbmoded_diag_mode)
+    if(!usbmoded_get_diag_mode())
     {
         /* check dynamic modes */
         if(usbmoded_modelist)

diff --git a/src/usb_moded-control.c b/src/usb_moded-control.c
@@ -237,7 +237,7 @@ void control_select_usb_mode(void)
         goto EXIT;
     }
 
-    if( usbmoded_diag_mode ) {
+    if( usbmoded_get_diag_mode() ) {
         log_debug("Entering diagnostic mode!\n");
         if( usbmoded_modelist ) {
             /* XXX 1st entry is just assumed to be diag mode??? */

diff --git a/src/usb_moded.c b/src/usb_moded.c
@@ -104,6 +104,8 @@
 
 /* -- usbmoded -- */
 
+bool            usbmoded_get_diag_mode             (void);
+void            usbmoded_set_diag_mode             (bool diag_mode);
 void            usbmoded_set_cable_connection_delay(int delay_ms);
 int             usbmoded_get_cable_connection_delay(void);
 static gboolean usbmoded_allow_suspend_timer_cb    (gpointer aptr);
@@ -128,7 +130,6 @@ GList            *usbmoded_modelist       = 0;
 static int        usbmoded_exitcode       = EXIT_FAILURE;
 static GMainLoop *usbmoded_mainloop       = NULL;
 bool              usbmoded_rescue_mode    = false;
-bool              usbmoded_diag_mode      = false;
 static bool       usbmoded_hw_fallback    = false;
 #ifdef SYSTEMD
 static bool       usbmoded_systemd_notify = false;
@@ -138,6 +139,30 @@ static bool       usbmoded_systemd_notify = false;
  * Functions
  * ========================================================================= */
 
+/* ------------------------------------------------------------------------- *
+ * DIAG_MODE
+ * ------------------------------------------------------------------------- */
+
+/** Diagnostic mode active
+ *
+ * In diag mode usb-moded uses separate mode configuration which
+ * should have exactly one mode defined / available.
+ */
+static bool usbmoded_diag_mode = false;
+
+bool usbmoded_get_diag_mode(void)
+{
+    return usbmoded_diag_mode;
+}
+
+void usbmoded_set_diag_mode(bool diag_mode)
+{
+    if( usbmoded_diag_mode != diag_mode ) {
+        log_info("diag_mode: %d -> %d",  usbmoded_diag_mode, diag_mode);
+        usbmoded_diag_mode = diag_mode;
+    }
+}
+
 /* ------------------------------------------------------------------------- *
  * CABLE_CONNECT_DELAY
  * ------------------------------------------------------------------------- */
@@ -348,7 +373,7 @@ void usbmoded_handle_signal(int signum)
         /* free and read in modelist again */
         dynconfig_free_mode_list(usbmoded_modelist);
 
-        usbmoded_modelist = dynconfig_read_mode_list(usbmoded_diag_mode);
+        usbmoded_modelist = dynconfig_read_mode_list(usbmoded_get_diag_mode());
 
         common_send_supported_modes_signal();
         common_send_available_modes_signal();
@@ -422,11 +447,11 @@ static bool usbmoded_init(void)
     }
 
 #ifdef APP_SYNC
-    appsync_read_list(usbmoded_diag_mode);
+    appsync_read_list(usbmoded_get_diag_mode());
 #endif
 
     /* always read dyn modes even if appsync is not used */
-    usbmoded_modelist = dynconfig_read_mode_list(usbmoded_diag_mode);
+    usbmoded_modelist = dynconfig_read_mode_list(usbmoded_get_diag_mode());
 
     if(config_check_trigger())
         trigger_init();
@@ -697,7 +722,7 @@ static void usbmoded_parse_options(int argc, char* argv[])
             break;
 
         case 'd':
-            usbmoded_diag_mode = true;
+            usbmoded_set_diag_mode(true);
             break;
 
         case 'h':

diff --git a/src/usb_moded.h b/src/usb_moded.h
@@ -68,14 +68,16 @@
  */
 extern bool            usbmoded_rescue_mode;
 
-extern bool usbmoded_diag_mode;
-
 extern GList *usbmoded_modelist;
 
 /* ========================================================================= *
  * Functions
  * ========================================================================= */
 
+/* -- usbmoded -- */
+
+bool usbmoded_get_diag_mode             (void);
+void usbmoded_set_diag_mode             (bool diag_mode);
 void usbmoded_set_cable_connection_delay(int delay_ms);
 int  usbmoded_get_cable_connection_delay(void);
 void usbmoded_allow_suspend             (void);