Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[dyn-config] Fix miscellaneous issues
String fields in modedata_t structures are filled in via functions that return 'gchar *' pointers - adjust structure data types and release function accordingly. The modelist_free() function uses g_list_foreach() iterator and a callback function that is not appropriate for the action, and then uses a cast to hide any compiler warnings - get rid of the cast by using g_list_free_full() iterator and a suitable callback function. The modelist_load() function looks complex and indiscriminately loads all files from dynamic mode configuration directory. If there are for example editor backup files present, this can lead to hard to detect issues - simplify the logic and use glob pattern expansion to derive list of files to load. Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>
- Loading branch information
Showing
2 changed files
with
123 additions
and
125 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters