Commit 1b48f524 authored by Philippe De Swert's avatar Philippe De Swert

[connection-sharing] Avoid crash when no secondary dns is given in connman

Signed-off-by: default avatarPhilippe De Swert <>
parent b0ca238f
......@@ -427,7 +427,7 @@ static int connman_fill_connection_data(DBusMessage *reply, struct ipforward_dat
DBusMessageIter array_iter, dict_iter, inside_dict_iter, variant_iter;
DBusMessageIter sub_array_iter, string_iter;
int type;
int type, next;
char *string;
log_debug("Filling in dns data\n");
......@@ -464,7 +464,14 @@ static int connman_fill_connection_data(DBusMessage *reply, struct ipforward_dat
dbus_message_iter_get_basic(&string_iter, &string);
log_debug("dns = %s\n", string);
ipforward->dns1 = strdup(string);
dbus_message_iter_next (&string_iter);
next = dbus_message_iter_next (&string_iter);
log_debug("No secundary dns\n");
/* FIXME: set the same dns for dns2 to avoid breakage */
ipforward->dns2 = strdup(string);
dbus_message_iter_get_basic(&string_iter, &string);
log_debug("dns2 = %s\n", string);
ipforward->dns2 = strdup(string);
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment