Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[telepathy-sasl-signon] Only set CredentialsNeedUpdate flag when appr…
…opriate

Previously, the CredentialsNeedUpdate flag would be set in a variety
of situations, including when a generic OperationFailed error occurred.
This commit ensures that it is only set for an account when a
UserInteraction error occurs (that is, the account credentials are
valid but need to be refreshed manually by the user).
  • Loading branch information
Chris Adams committed Dec 10, 2013
1 parent 08eb697 commit 1d50662
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions telepathy-sasl-signon/empathy-uoa-auth-handler.c
Expand Up @@ -224,11 +224,7 @@ session_process_cb (SignonAuthSession *session,
if (error != NULL)
{
DEBUG ("Error processing the session: %s", error->message);
if (g_error_matches(error, SIGNON_ERROR, SIGNON_ERROR_CREDENTIALS_NOT_AVAILABLE) ||
g_error_matches(error, SIGNON_ERROR, SIGNON_ERROR_INVALID_CREDENTIALS) ||
g_error_matches(error, SIGNON_ERROR, SIGNON_ERROR_MISSING_DATA) ||
g_error_matches(error, SIGNON_ERROR, SIGNON_ERROR_USER_INTERACTION) ||
g_error_matches(error, SIGNON_ERROR, SIGNON_ERROR_OPERATION_FAILED))
if (g_error_matches(error, SIGNON_ERROR, SIGNON_ERROR_USER_INTERACTION))
{
request_password(ctx);
}
Expand Down

0 comments on commit 1d50662

Please sign in to comment.