Skip to content

Commit

Permalink
[ssu] Use SsuRepo struct for listRepos
Browse files Browse the repository at this point in the history
  • Loading branch information
Andrey Kozhevnikov committed Jul 11, 2018
1 parent 4b60d6d commit f10a500
Show file tree
Hide file tree
Showing 8 changed files with 52 additions and 15 deletions.
6 changes: 3 additions & 3 deletions dbus/org.nemo.ssu.xml
Expand Up @@ -94,9 +94,9 @@
<arg direction="in" type="s" name="url" />
</method>
<method name="listRepos">
<annotation name="org.qtproject.QtDBus.QtTypeName.Out0" value="QVariantList"/>
<arg direction="in" type="b" name="rnd" />
<arg direction="out" type="a(v)" name="repos"/>
<arg type="a(ssa{sv})" direction="out"/>
<annotation name="org.qtproject.QtDBus.QtTypeName.Out0" value="QList&lt;SsuRepo&gt;"/>
<arg name="rnd" type="b" direction="in"/>
</method>
<method name="updateRepos">
</method>
Expand Down
2 changes: 2 additions & 0 deletions ssucli/ssucli.cpp
Expand Up @@ -22,6 +22,8 @@
SsuCli::SsuCli()
: QObject()
{
qDBusRegisterMetaType<SsuRepo>();

connect(this, SIGNAL(done()),
QCoreApplication::instance(), SLOT(quit()), Qt::DirectConnection);
connect(&ssu, SIGNAL(done()),
Expand Down
2 changes: 1 addition & 1 deletion ssucli/ssucli.pro
Expand Up @@ -11,5 +11,5 @@ SOURCES = main.cpp \

ssu_dbus_interface.files = ../dbus/org.nemo.ssu.xml
ssu_dbus_interface.source_flags = -c SsuProxy
ssu_dbus_interface.header_flags = -c SsuProxy -i ssud/ssud_include.h
ssu_dbus_interface.header_flags = -c SsuProxy -i ssud/ssud_dbus.h
DBUS_INTERFACES += ssu_dbus_interface
13 changes: 10 additions & 3 deletions ssud/ssud.cpp
Expand Up @@ -19,6 +19,8 @@ const char *Ssud::OBJECT_PATH = "/org/nemo/ssu";
Ssud::Ssud(QObject *parent)
: QObject(parent)
{
qDBusRegisterMetaType<SsuRepo>();
qDBusRegisterMetaType<QList<SsuRepo>>();
QDBusConnection connection = QDBusConnection::systemBus();
if (!connection.registerObject(OBJECT_PATH, this)) {
qFatal("Cannot register object at %s", OBJECT_PATH);
Expand Down Expand Up @@ -232,14 +234,19 @@ void Ssud::updateRepos()
autoclose.start();
}

QVariantList Ssud::listRepos(bool rnd)
QList<SsuRepo> Ssud::listRepos(bool rnd)
{
QVariantList reposList;
QList<SsuRepo> reposList;
SsuRepoManager repoManager;

for (const QString &repo : repoManager.repos(rnd)) {
const QString repoUrl = ssu.repoUrl(repo, rnd);
reposList << QVariantMap({{ "url", repoUrl }, { "name", repo }});

SsuRepo ssuRepo;
ssuRepo.name = repo;
ssuRepo.url = repoUrl;

reposList.append(ssuRepo);
}
autoclose.start();
return reposList;
Expand Down
4 changes: 2 additions & 2 deletions ssud/ssud.h
Expand Up @@ -13,7 +13,7 @@
#include <QTimer>

#include "libssu/ssu.h"
#include "ssud_include.h"
#include "ssud_dbus.h"

class Ssud: public QObject
{
Expand Down Expand Up @@ -46,7 +46,7 @@ public slots:
void modifyRepo(int action, const QString &repo);
void addRepo(const QString &repo, const QString &url);
void updateRepos();
QVariantList listRepos(bool rnd);
QList<SsuRepo> listRepos(bool rnd);

bool error();
QString lastError();
Expand Down
4 changes: 2 additions & 2 deletions ssud/ssud.pro
Expand Up @@ -7,7 +7,7 @@ CONFIG += link_pkgconfig

HEADERS = \
ssud.h \
ssud_include.h
ssud_dbus.h
SOURCES = \
ssud.cpp \
main.cpp
Expand All @@ -27,5 +27,5 @@ INSTALLS += systemd service conf

ssu_dbus_adaptor.files = ../dbus/org.nemo.ssu.xml
ssu_dbus_adaptor.source_flags = -c SsuAdaptor
ssu_dbus_adaptor.header_flags = -c SsuAdaptor -i ssud/ssud_include.h
ssu_dbus_adaptor.header_flags = -c SsuAdaptor -i ssud/ssud_dbus.h
DBUS_ADAPTORS += ssu_dbus_adaptor
32 changes: 32 additions & 0 deletions ssud/ssud_dbus.h
@@ -0,0 +1,32 @@
#ifndef SSUD_INCLUDE_H
#define SSUD_INCLUDE_H

#include <QDBusArgument>
#include <QString>
#include <QVariantMap>

struct SsuRepo {
QString name;
QString url;
QVariantMap parameters;
};

inline QDBusArgument &operator<<(QDBusArgument &argument, const SsuRepo &myRepo)
{
argument.beginStructure();
argument << myRepo.name << myRepo.url << myRepo.parameters;
argument.endStructure();
return argument;
}

inline const QDBusArgument &operator>>(const QDBusArgument &argument, SsuRepo &myRepo)
{
argument.beginStructure();
argument >> myRepo.name >> myRepo.url >> myRepo.parameters;
argument.endStructure();
return argument;
}

Q_DECLARE_METATYPE(SsuRepo)

#endif // SSUD_INCLUDE_H
4 changes: 0 additions & 4 deletions ssud/ssud_include.h

This file was deleted.

0 comments on commit f10a500

Please sign in to comment.