Skip to content

Commit

Permalink
Don't invalidate textures when the scene graph is stopped.
Browse files Browse the repository at this point in the history
The texture often represents the last reference to the last buffer of
a destroyed surface and invalidating releases that reference which
shortcuts any attempt to keep the buffer alive with QWaylandUnmapLock.

Change-Id: I4641a87a32f8639c3ffb6c3b5dafd21c77bbb2c1
Reviewed-by: Giulio Camuffo <giulio.camuffo@jollamobile.com>
  • Loading branch information
denexter committed Sep 9, 2015
1 parent bf46e15 commit 40e23af
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/compositor/compositor_api/qwaylandquicksurface.cpp
Expand Up @@ -169,7 +169,6 @@ QWaylandQuickSurface::QWaylandQuickSurface(wl_client *client, quint32 id, int ve
QQuickWindow *window = static_cast<QQuickWindow *>(compositor->window());
connect(window, &QQuickWindow::beforeSynchronizing, this, &QWaylandQuickSurface::updateTexture, Qt::DirectConnection);
connect(window, &QQuickWindow::sceneGraphInvalidated, this, &QWaylandQuickSurface::invalidateTexture, Qt::DirectConnection);
connect(window, &QQuickWindow::sceneGraphAboutToStop, this, &QWaylandQuickSurface::invalidateTexture, Qt::DirectConnection);
connect(this, &QWaylandSurface::windowPropertyChanged, d->windowPropertyMap, &QQmlPropertyMap::insert);
connect(d->windowPropertyMap, &QQmlPropertyMap::valueChanged, this, &QWaylandSurface::setWindowProperty);

Expand Down

0 comments on commit 40e23af

Please sign in to comment.