- 20 Mar, 2012 11 commits
-
-
Bea Lam authored
Currently the item focus data is not updated if it is not in a canvas. This means a subFocusItem may be deleted when the item is outside of a canvas, creating a stale pointer when the item is moved back into a canvas. This change also means that the last item to set focus=true will now consistently get activeFocus. Previously if an item did not have a canvas and then was moved back into the canvas, the first item found with focus=true would get activeFocus. Task-number: QTBUG-24616 Change-Id: Ia706bd6ba6bcbccd616b5019c7c0fae4c39afa7f Reviewed-by:
Andrew den Exter <andrew.den-exter@nokia.com>
-
Kent Hansen authored
If you pass (void*)0 to QJSEngine::toScriptValue(), or you pass a QVariant of type QMetaType::VoidStar containing a 0 value, you get back a QJSValue of type null (isNull() returns true); that's fine. However, if you called QJSValue::toVariant() on a JS null value, you would get back an invalid QVariant. The expected result is a QVariant of type QMetaType::VoidStar containing a 0 value. This makes the conversion of the JS null type symmetric and avoids loss of data. Change-Id: Ifa6e788152118f80adf9c2d7be1283f053b44294 Reviewed-by:
Jędrzej Nowacki <jedrzej.nowacki@nokia.com> Reviewed-by:
Simon Hausmann <simon.hausmann@nokia.com>
-
Andrew den Exter authored
Word selection initiated by a double click in QTextEdit only selects a word if the drag point is closer to the end than the start (assuming ltr selection) which can make it difficult to select small words with touch input, as such the SelectWords mouseSelectionMode of TextEdit selected a word if the drag point intersected any part of the word. Since we no longer have to retain compability for QTextEdit we can settle on a single behaviour for word selection. Change-Id: Iaabb7938a2b61b84a290a9ee41e407c83144b96f Reviewed-by:
Yann Bodson <yann.bodson@nokia.com>
-
Andrew den Exter authored
Change-Id: Ie77a61a3ea0d1bdccd59dd519346db74bdf59c44 Reviewed-by:
Yann Bodson <yann.bodson@nokia.com>
-
Charles Yin authored
Task-number: QTBUG-24790 Change-Id: I1d78df79568389f8c59f99ace9e2d7685b5d8f0d Reviewed-by:
Martin Jones <martin.jones@nokia.com>
-
Charles Yin authored
The minimum window width in Windows 7 requires more than 100, so make the item width to 200 to avoid test failures. Task-number: QTBUG-24787 Change-Id: I439528a94aed9c54eca0fa68651c84afa4f9ab13 Reviewed-by:
Martin Jones <martin.jones@nokia.com>
-
Charles Yin authored
Task-number: QTBUG-24777 Change-Id: I819c2e07b23e8740f7570f117dafb2340f7c00e9 Reviewed-by:
Martin Jones <martin.jones@nokia.com>
-
Michael Brasser authored
Change-Id: I66602bf52986a388f9b6fe2bcd4630b862138906 Reviewed-by:
Roberto Raggi <roberto.raggi@nokia.com>
-
Martin Jones authored
If Loader was either destroyed, or its source changed while it was incubating the itemContext could be leaked. Change-Id: I5b749062552954d92bf2851250f942b20ebbfe68 Reviewed-by:
Andrew den Exter <andrew.den-exter@nokia.com>
-
Martin Jones authored
If the mouse grab is stolen, return to allowed bounds. Change-Id: Icc44da32ff62bed273f0ccbb5498766981cdf9a4 Reviewed-by:
Michael Brasser <michael.brasser@nokia.com>
-
Matthew Vogt authored
Add an optional parameter to the Qt.createComponent function which allows the caller to specify the object that will become the parent for the created component. If the parent is not specified by the caller, it becomes the QML engine; this behavior will change in the near future to allow these component objects to be collected when no longer referenced. Task-number: QTBUG-24840 Change-Id: I2742133fe8ab8cbc80d8012a9d9b9fc2e4596fca Reviewed-by:
Martin Jones <martin.jones@nokia.com>
-
- 19 Mar, 2012 15 commits
-
-
Matthew Vogt authored
When a module exports functionality provided by a script, ensure that imported script modules inside that script resolve correctly. Task-number: QTBUG-24596 Change-Id: I3885dcc56946423f0d7cf00afdcdfaa0cb11967a Reviewed-by:
Chris Adams <christopher.adams@nokia.com>
-
Aurindam Jana authored
Change-Id: Ie0e1b6e9edd6a09fef565635cc793f8bdb6c42e7 Reviewed-by:
Kai Koehne <kai.koehne@nokia.com>
-
Aurindam Jana authored
Change-Id: If20b53d2e47cdc4ed54df0d9360ae1b0566489c6 Reviewed-by:
Kai Koehne <kai.koehne@nokia.com>
-
Miikka Heikkinen authored
Fixed by adding proper .gitattributes for the tests Task-number: QTBUG-24780 Change-Id: If8de0161a377c21fb5c6327d69e8da84174ee435 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@nokia.com> Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
-
Kai Koehne authored
Don't rely on QML_DISABLE_OPTIMIZER environment variable being set. Change-Id: Ib1a9d83eb9698adcd3c9a5bbcc74cba382836078 Reviewed-by:
Aurindam Jana <aurindam.jana@nokia.com>
-
Aurindam Jana authored
Rename service from QDeclarativeEngine to QmlDebugger. Send a response for each query. Change-Id: I01cfeaf3e4116bfd7029d170ee228c159973947c Reviewed-by:
Kai Koehne <kai.koehne@nokia.com>
-
Simjees Abraham authored
Change-Id: I5bb2e48e2ad2019b8a92f6f8842b88027fcd2d28 Reviewed-by:
Kai Koehne <kai.koehne@nokia.com>
-
Aurindam Jana authored
Remove dependencies on quick-private from all possible debugging auto tests and list them under public tests. Change-Id: I688b5b36fdf3d6fbcb6cef2a975ecd1bf679af2b Reviewed-by:
Kai Koehne <kai.koehne@nokia.com>
-
Charles Yin authored
Windows currently does not support font loader yet. Change-Id: I370e41c1f2e2a45787741414a6e7bf00cc3f6c3e Reviewed-by:
Martin Jones <martin.jones@nokia.com>
-
Charles Yin authored
Change-Id: Ib7399f9a005d3674fcb46c605cea3a8d40c21284 Reviewed-by:
Martin Jones <martin.jones@nokia.com>
-
Aurindam Jana authored
All created instances are stored under the root context. Check for the creation context of the object when building up the tree. Do the same when building up the states list. Change-Id: I8716d9966a61b8f7cb3ad4b7ab5acd4c94b4cd03 Reviewed-by:
Kai Koehne <kai.koehne@nokia.com>
-
Martin Jones authored
If an incubator is cleared while waiting for other incubators to complete also clear the incubators it is waiting for. Change-Id: I83470920c0fd8a23d0098849192555f7478bb492 Reviewed-by:
Andrew den Exter <andrew.den-exter@nokia.com>
-
Martin Jones authored
Geometry listeners were called for deleted header/footer. Change-Id: I47854178232f8a4ab5e19a931901b49741fec388 Reviewed-by:
Bea Lam <bea.lam@nokia.com>
-
Martin Jones authored
If the model is cleared or replaced with an empty one, the section headers should be released. Change-Id: Ia2f070c312593743b2c5332a6c69facaf222ee6d Reviewed-by:
Bea Lam <bea.lam@nokia.com>
-
Andrew den Exter authored
Switch to a QTRY_COMPARE to allow a little more time processing the event loop. Change-Id: I4f14feb5cbc7d11654f6c9089baff4ae67d894db Reviewed-by:
Martin Jones <martin.jones@nokia.com>
-
- 15 Mar, 2012 9 commits
-
-
Michael Brasser authored
Change-Id: I184065e0b7c8c6536f2081b9bf03e98992a4c9fe Reviewed-by:
Roberto Raggi <roberto.raggi@nokia.com>
-
Miikka Heikkinen authored
Fixed by using testFileUrl() shared utility function where appropriate instead of testFile() or various other ways file URLs were being incorrectly used. Task-number: QTBUG-24779 Change-Id: I48cbd297d419238f42ea45132344b7e5a487b6f1 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@nokia.com>
-
Miikka Heikkinen authored
MSVC doesn't support setenv or unsetenv functions, so use qputenv instead. Change-Id: Ife4eb056e6c87d23774512c61b13a3ae3d8ac9ce Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@nokia.com>
-
Martin Jones authored
Enables threaded compilation for a Loader "source". Change-Id: I2d60a3ace07aab58f3b8f069e45a2864178c959f Reviewed-by:
Chris Adams <christopher.adams@nokia.com>
-
Alan Alpert authored
Already cleared focus should exit the function without terminating the runtime. Task-number: QTBUG-24714 Change-Id: Ia8c6be0d88e43d1f71112acc7bac3eb674f22de8 Reviewed-by:
Martin Jones <martin.jones@nokia.com>
-
Martin Jones authored
Shouldn't throw anything away by default. Also fix bug that flicking back into bounds from outside bounds halved velocity. Change-Id: I3c2d303a9e46910439dc8bfb01771376f634a684 Reviewed-by:
Laszlo Agocs <laszlo.p.agocs@nokia.com> Reviewed-by:
Michael Brasser <michael.brasser@nokia.com>
-
Chris Adams authored
If a var property of a QObject is read after the v8 data associated with the qobject has been deleted but prior to the DeferredDelete event being processed, the varProperties array will be null and a crash will occur. This patch ensures that we check for this condition in both the access and set codepaths for var properties, and also ensures that an object which has previously been queued for deletion cannot be referenced in JS. Finally, it adds a unit test to ensure that we don't regress. Task-number: QTBUG-24748 Change-Id: Idde384ca01e18f4dcf9e376e9379f2c5eb410e14 Reviewed-by:
Michael Brasser <michael.brasser@nokia.com>
-
Chris Adams authored
Both of those unit tests currently change the ownership of the test instance object, which could result in it being collected by the JS GC and deleted if events were processed. Change-Id: I5a9821fb56e19af1d52fea46e54755875dfbb29a Reviewed-by:
Michael Brasser <michael.brasser@nokia.com>
-
Aaron Kennedy authored
This is the first step to creating much lighter weight bindings that are tuned for the specific scenario in which they're used. Change-Id: Ib985dcff25679b711b5c634bbc891aa7902bf405 Reviewed-by:
Michael Brasser <michael.brasser@nokia.com>
-
- 14 Mar, 2012 5 commits
-
-
Chris Adams authored
Previously, when a QObject ptr was stored in a dynamic variant property, the value of the property could change (to a zero ptr) if the QObject was deleted without a notify signal being emitted by the QDeclarativeVMEMetaObject which stores the property. This commit ensures that such a notify signal is emitted correctly. Task-number: QTBUG-23451 Change-Id: I5689abd984b177737f8d5f18950838b73ebde328 Reviewed-by:
Martin Jones <martin.jones@nokia.com>
-
Kent Hansen authored
Only V8 knows whether a failed property lookup should actually cause a ReferenceError to be thrown. When evaluating a "typeof" expression, for example, a ReferenceError should not be thrown even if the expression involves global variables that don't exist, according to the ECMA-262 specification. QML should try to match the standard JavaScript behavior. This is achieved by simply returning an empty value handle (to signify the absence of the property), and leaving it to V8 to throw an exception as appropriate. Task-number: QTBUG-21864 Task-number: QTBUG-24448 Change-Id: I9945adcab98fc3b801371163367473d6af0ab31a Reviewed-by:
Aaron Kennedy <aaron.kennedy@nokia.com>
-
Miikka Heikkinen authored
There is no dummy.qml, so trying to find it will cause a warning and return an empty string. Since the url is optional anyway and apparently not relevant to this test, just use empty QUrl directly. Change-Id: I11ba742dedccd6bdea226f680aa57c957afc7dc7 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@nokia.com>
-
Miikka Heikkinen authored
These tests are marked insignificant for now to make CI runs pass. Insignifications need to be removed once the related issues are fixed. Change-Id: I3a1d36e5b17cf2f1b2f00b20b615359d96975f2b Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@nokia.com>
-
Kent Hansen authored
Instead of "Can't find variable: foo", use "foo is not defined". This is in preparation of letting V8 throw the exception when a property lookup fails on the QML scope object (needed for QTBUG-24448). Change-Id: I3c747482a8ef138dad9a85530a4f6b5c4c818a03 Reviewed-by:
Aaron Kennedy <aaron.kennedy@nokia.com>
-