Skip to content

Commit

Permalink
Remove QJSValue::isFunction() function
Browse files Browse the repository at this point in the history
Rationale: QJSValue::isCallable() should be used instead. There is no
compelling reason to be able to distinguish between JS Function
instances and other callable objects.

Task-number: QTBUG-23604
Change-Id: Ieef6b32030ef70f54081035fd4ffc3c17c184cd3
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
  • Loading branch information
Kent Hansen authored and Qt by Nokia committed Feb 2, 2012
1 parent 9e7e0c1 commit fe6173c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 18 deletions.
16 changes: 0 additions & 16 deletions src/declarative/qml/v8/qjsvalue.cpp
Expand Up @@ -324,22 +324,6 @@ bool QJSValue::isCallable() const
return d->isCallable();
}

#ifdef QT_DEPRECATED

/*!
\obsolete
Use isCallable() instead.
*/
bool QJSValue::isFunction() const
{
Q_D(const QJSValue);
QScriptIsolate api(d->engine());
return d->isCallable();
}

#endif // QT_DEPRECATED

/*!
Returns true if this QJSValue is a variant value;
otherwise returns false.
Expand Down
2 changes: 0 additions & 2 deletions src/declarative/qml/v8/qjsvalue.h
Expand Up @@ -119,8 +119,6 @@ class Q_DECLARATIVE_EXPORT QJSValue

#ifdef QT_DEPRECATED
QT_DEPRECATED QJSEngine *engine() const;

QT_DEPRECATED bool isFunction() const;
#endif

private:
Expand Down

0 comments on commit fe6173c

Please sign in to comment.