Skip to content

Commit

Permalink
Remove QJSValue::construct() and deprecated call() overload
Browse files Browse the repository at this point in the history
callAsConstructor() should be used instead.

Task-number: QTBUG-23604
Change-Id: If95ab9906712ede7cbae5e9d24624708bccf880f
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
  • Loading branch information
Kent Hansen authored and Qt by Nokia committed Feb 2, 2012
1 parent 88cb064 commit 9e7e0c1
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 29 deletions.
24 changes: 0 additions & 24 deletions src/declarative/qml/v8/qjsvalue.cpp
Expand Up @@ -555,30 +555,6 @@ QJSValue QJSValue::callAsConstructor(const QJSValueList &args)

#ifdef QT_DEPRECATED

/*!
\obsolete
Use callWithInstance() instead.
*/
QJSValue QJSValue::call(const QJSValue& thisObject, const QJSValueList& args)
{
Q_D(QJSValue);
QScriptIsolate api(d->engine());
return d->call(QJSValuePrivate::get(thisObject), args);
}

/*!
\obsolete
Use callAsConstructor() instead.
*/
QJSValue QJSValue::construct(const QJSValueList &args)
{
Q_D(QJSValue);
QScriptIsolate api(d->engine());
return QJSValuePrivate::get(d->callAsConstructor(args));
}

/*!
\obsolete
Expand Down
6 changes: 1 addition & 5 deletions src/declarative/qml/v8/qjsvalue.h
Expand Up @@ -113,18 +113,14 @@ class Q_DECLARATIVE_EXPORT QJSValue
bool deleteProperty(const QString &name);

bool isCallable() const;
QJSValue call(const QJSValueList &args);
QJSValue call(const QJSValueList &args = QJSValueList());
QJSValue callWithInstance(const QJSValue &instance, const QJSValueList &args = QJSValueList());
QJSValue callAsConstructor(const QJSValueList &args = QJSValueList());

#ifdef QT_DEPRECATED
QT_DEPRECATED QJSEngine *engine() const;

QT_DEPRECATED bool isFunction() const;

QT_DEPRECATED QJSValue call(const QJSValue &thisObject = QJSValue(),
const QJSValueList &args = QJSValueList());
QT_DEPRECATED QJSValue construct(const QJSValueList &args = QJSValueList());
#endif

private:
Expand Down

0 comments on commit 9e7e0c1

Please sign in to comment.