Skip to content

Commit

Permalink
Merge branch 'jb51610_fix' into 'mer-5.6'
Browse files Browse the repository at this point in the history
[qtnetwork] Fix freeing certificates. Fixes JB#51610

See merge request mer-core/qtbase!67
  • Loading branch information
rainemak committed Oct 21, 2020
2 parents 84c5236 + 57ccecd commit 09e2e31
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/network/ssl/qsslsocket_openssl.cpp
Expand Up @@ -1825,7 +1825,7 @@ bool QSslSocketBackendPrivate::importPkcs12(QIODevice *device,
// Convert to Qt types
if (!key->d->fromEVP_PKEY(pkey)) {
qCWarning(lcSsl, "Unable to convert private key");
q_sk_pop_free(reinterpret_cast<STACK *>(ca), reinterpret_cast<void(*)(void*)>(q_sk_free));
q_sk_pop_free(reinterpret_cast<STACK *>(ca), reinterpret_cast<void(*)(void*)>(q_X509_free));
q_X509_free(x509);
q_EVP_PKEY_free(pkey);
q_PKCS12_free(p12);
Expand All @@ -1840,7 +1840,7 @@ bool QSslSocketBackendPrivate::importPkcs12(QIODevice *device,
*caCertificates = QSslSocketBackendPrivate::STACKOFX509_to_QSslCertificates(ca);

// Clean up
q_sk_pop_free(reinterpret_cast<STACK *>(ca), reinterpret_cast<void(*)(void*)>(q_sk_free));
q_sk_pop_free(reinterpret_cast<STACK *>(ca), reinterpret_cast<void(*)(void*)>(q_X509_free));
q_X509_free(x509);
q_EVP_PKEY_free(pkey);
q_PKCS12_free(p12);
Expand Down

0 comments on commit 09e2e31

Please sign in to comment.