QDebug instantiation can be heavy

Signed-off-by: Denis Zalevskiy <denis.zalevskiy@jolla.com>
sailfishos · Oct 7, 2014 · a871765 · a871765
1 parent 0a8ce73
commit a871765
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 13 deletions.
diff --git a/include/qtaround/error.hpp b/include/qtaround/error.hpp
@@ -28,22 +28,13 @@ class Error : public std::exception
 public:
     Error(QVariantMap const &from) : m(from) {}
     virtual ~Error() noexcept(true) {}
-    virtual const char* what() const noexcept(true)
-    {
-        if (s.isEmpty())
-            s = dump(m);
-        return s.toUtf8();
-    }
+    virtual const char* what() const noexcept(true);
 
     QVariantMap m;
     mutable QString s;
 };
 
-static inline QDebug operator << (QDebug dst, error::Error const &src)
-{
-    dst << src.m;
-    return dst;
-}
+QDebug operator << (QDebug dst, error::Error const &src);
 
 static inline void raise(QVariantMap const &m)
 {

diff --git a/src/util.cpp b/src/util.cpp
@@ -1,7 +1,6 @@
 /**
  * @file util.cpp
  * @brief Misc. helpful utilities
- * @author Denis Zalevskiy <denis.zalevskiy@jolla.com>
  * @copyright (C) 2014 Jolla Ltd.
  * @par License: LGPL 2.1 http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html
  */
@@ -12,7 +11,25 @@
 #include <QString>
 #include <QMap>
 
-namespace qtaround { namespace util {
+namespace qtaround {
+
+namespace error {
+const char* Error::what() const noexcept(true)
+{
+    if (s.isEmpty())
+        s = dump(m);
+    return s.toUtf8();
+}
+
+QDebug operator << (QDebug dst, error::Error const &src)
+{
+    dst << src.m;
+    return dst;
+}
+
+}
+
+namespace util {
 
 namespace {