Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
build-sys: Move ORC_SOURCE definitions outside of "if HAVE_ORC"
Not having ORC_SOURCE defined results in different tarballs depending on
whether the dev issuing 'make dist' has orc support enabled or disabled.

Specifying ORC_SOURCE unconditionally addresses that, without causing
negative effects on users not having orc in the end.
  • Loading branch information
DimStar77 authored and tanuk committed Jan 24, 2014
1 parent 0779caf commit a360b29
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions orc.mak
Expand Up @@ -22,6 +22,7 @@

EXTRA_DIST += $(addsuffix .orc,$(ORC_SOURCE))

if HAVE_ORC
ORC_BUILT_SOURCE = $(addsuffix -orc-gen.c,$(ORC_SOURCE))
ORC_BUILT_HEADER = $(addsuffix -orc-gen.h,$(ORC_SOURCE))

Expand All @@ -44,3 +45,4 @@ cp_v_gen_0 = @echo " CP $@";
%-orc-gen.h: %.orc
@mkdir -p $(@D)
$(orcc_v_gen)$(ORCC) --header -o $@ $<
endif
4 changes: 2 additions & 2 deletions src/Makefile.am
Expand Up @@ -932,8 +932,8 @@ libpulsecore_mix_neon_la_CFLAGS = $(AM_CFLAGS) $(NEON_CFLAGS)
libpulsecore_@PA_MAJORMINOR@_la_LIBADD += libpulsecore_sconv_neon.la libpulsecore_mix_neon.la
endif

if HAVE_ORC
ORC_SOURCE += pulsecore/svolume
if HAVE_ORC
libpulsecore_@PA_MAJORMINOR@_la_SOURCES += pulsecore/svolume_orc.c
nodist_libpulsecore_@PA_MAJORMINOR@_la_SOURCES = pulsecore/svolume-orc-gen.c pulsecore/svolume-orc-gen.h
libpulsecore_@PA_MAJORMINOR@_la_CFLAGS += $(ORC_CFLAGS)
Expand Down Expand Up @@ -1950,8 +1950,8 @@ module_echo_cancel_la_SOURCES += \
modules/echo-cancel/adrian-aec.c modules/echo-cancel/adrian-aec.h \
modules/echo-cancel/adrian.c modules/echo-cancel/adrian.h
module_echo_cancel_la_CFLAGS += -DHAVE_ADRIAN_EC=1
if HAVE_ORC
ORC_SOURCE += modules/echo-cancel/adrian-aec
if HAVE_ORC
nodist_module_echo_cancel_la_SOURCES = \
modules/echo-cancel/adrian-aec-orc-gen.c \
modules/echo-cancel/adrian-aec-orc-gen.h
Expand Down

0 comments on commit a360b29

Please sign in to comment.