Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'jb45678-pppd-unroot' into 'master'
[ppp] [pppd] Update to version 2.4.8, fix CVE-2015-3310. JB#48797 See merge request mer-core/ppp!3
- Loading branch information
Showing
4 changed files
with
21 additions
and
113 deletions.
There are no files selected for viewing
Submodule ppp
updated
from 846842 to 8d4544
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
Fix buffer overflow in rc_mksid() | ||
|
||
rc_mksid converts the PID of pppd to hex to generate a pseudo-unique string. | ||
If the process id is bigger than 65535 (FFFF), its hex representation will be | ||
longer than 4 characters, resulting in a buffer overflow. | ||
|
||
The bug can be exploited to cause a remote DoS. | ||
--- ppp-2.4.7/pppd/plugins/radius/util.c | ||
+++ ppp-2.4.7/pppd/plugins/radius/util.c | ||
@@ -77,7 +77,7 @@ rc_mksid (void) | ||
static unsigned short int cnt = 0; | ||
sprintf (buf, "%08lX%04X%02hX", | ||
(unsigned long int) time (NULL), | ||
- (unsigned int) getpid (), | ||
+ (unsigned int) getpid () & 0xFFFF, | ||
cnt & 0xFF); | ||
cnt++; | ||
return buf; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.