Skip to content

Commit

Permalink
[unit] Fixed unit tests failing against glib2 2.66. JB#51311
Browse files Browse the repository at this point in the history
I can't explain why those g_bus_own_name_on_connection() calls were
added to that unit test in the first place :|

In any case, taking them out makes unit tests happy.
  • Loading branch information
monich committed Oct 14, 2020
1 parent 4e48cfb commit 1a9784d
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions unit/plugins_dbus_handlers/test_plugins_dbus_handlers.c
@@ -1,6 +1,6 @@
/*
* Copyright (C) 2019 Jolla Ltd.
* Copyright (C) 2019 Slava Monich <slava.monich@jolla.com>
* Copyright (C) 2019-2020 Jolla Ltd.
* Copyright (C) 2019-2020 Slava Monich <slava.monich@jolla.com>
*
* You may use this file under the terms of BSD license as follows:
*
Expand Down Expand Up @@ -111,8 +111,6 @@ test_start(
/* Typical start callback */
g_assert(g_dbus_interface_skeleton_export(G_DBUS_INTERFACE_SKELETON
(test->dbus_handler), server, TEST_PATH, NULL));
g_assert(g_bus_own_name_on_connection(server, TEST_SERVICE,
G_BUS_NAME_OWNER_FLAGS_NONE, NULL, NULL, test, NULL));

test->handlers = dbus_handlers_new(client, test->dir);
g_assert(test->handlers);
Expand Down Expand Up @@ -184,8 +182,6 @@ test_cancel_start(

g_assert(g_dbus_interface_skeleton_export(G_DBUS_INTERFACE_SKELETON
(test->dbus_handler), server, TEST_PATH, NULL));
g_assert(g_bus_own_name_on_connection(server, TEST_SERVICE,
G_BUS_NAME_OWNER_FLAGS_NONE, NULL, NULL, test, NULL));

/* dbus_handlers_new will fail without config dir */
g_assert(!dbus_handlers_new(client, NULL));
Expand Down

0 comments on commit 1a9784d

Please sign in to comment.