Check that grp points to something before using it.

sailfishos · Apr 28, 2020 · 1c2fed1 · 1c2fed1
1 parent b6ff364
commit 1c2fed1
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/src/usermodel.cpp b/src/usermodel.cpp
@@ -88,11 +88,15 @@ UserModel::UserModel(QObject *parent)
     if (QDBusConnection::systemBus().interface()->isServiceRegistered(UserManagerService))
         createInterface();
     struct group *grp = getgrnam("users");
-    for (int i = 0; grp->gr_mem[i] != nullptr; ++i) {
-        UserInfo user(QString(grp->gr_mem[i]));
-        if (user.isValid()) { // Skip invalid users here
-            m_users.append(user);
-            m_uidsToRows.insert(user.uid(), m_users.count()-1);
+    if (!grp) {
+        qCWarning(lcUsersLog) << "Could not read users group:" << strerror(errno);
+    } else {
+        for (int i = 0; grp->gr_mem[i] != nullptr; ++i) {
+            UserInfo user(QString(grp->gr_mem[i]));
+            if (user.isValid()) { // Skip invalid users here
+                m_users.append(user);
+                m_uidsToRows.insert(user.uid(), m_users.count()-1);
+            }
         }
     }
     // grp must not be free'd