Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[mms_codec] Ignore unknown headers and continue parsing
There's no reason to stop parsing. The assumption was that unknown headers
will follow the old ones that we do support but that turned out not to be
the case in the real life.
  • Loading branch information
monich committed Apr 24, 2014
1 parent 9567dcf commit cab748c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions mms-lib/src/mms_codec.c
Expand Up @@ -1020,10 +1020,10 @@ static gboolean mms_parse_headers(struct wsp_header_iter *iter,
p = wsp_header_iter_get_hdr(iter);
h = p[0] & 0x7f;

/* Stop parsing when we see an unknown header */
/* Unknown header, skip */
handler = handler_for_type(h);
if (handler == NULL)
break;
continue;

/* Unsupported header, skip */
if (entries[h].data == NULL)
Expand Down
Binary file added mms-lib/test/mms_codec/data/m-retrieve_8.conf
Binary file not shown.
1 change: 1 addition & 0 deletions mms-lib/test/mms_codec/test_mms_codec.c
Expand Up @@ -65,6 +65,7 @@ int main(int argc, char* argv[])
"m-retrieve_5.conf",
"m-retrieve_6.conf",
"m-retrieve_7.conf",
"m-retrieve_8.conf",
"m-notifyresp.ind",
"m-read-rec.ind",
"m-send_1.req",
Expand Down

0 comments on commit cab748c

Please sign in to comment.