Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[tklock] Keep tklock submode and lockscreen state in sync. Fixes JB#4…
…2145

Looks like hard to reproduce problems like defunct device unlock view
and semi-active lockscreen might be caused by various glitches in mce
side tklock submode tracking and lockscreen state synchronization.

Force tklock submode datapipe changes to comply with lockscreen policy
by installing a datapipe filter instead of attempting to correct after
arriving to non-allowed state.

Sync lockscreen policy changes to tklock submode from idle callback
instead of using potentially hazardous recursive datapipe execution.

Use only lockscreen policy state when deciding how tklock state should
show up on D-Bus.

Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>
  • Loading branch information
spiiroin committed Sep 18, 2018
1 parent 1fa8a68 commit c4d2ffb
Show file tree
Hide file tree
Showing 2 changed files with 151 additions and 59 deletions.
2 changes: 1 addition & 1 deletion datapipe.c
Expand Up @@ -760,7 +760,7 @@ void mce_datapipe_init(void)
0, GINT_TO_POINTER(CALL_TYPE_NORMAL));
datapipe_init(&alarm_ui_state_pipe, READ_ONLY, DONT_FREE_CACHE,
0, GINT_TO_POINTER(MCE_ALARM_UI_INVALID_INT32));
datapipe_init(&submode_pipe, READ_ONLY, DONT_FREE_CACHE,
datapipe_init(&submode_pipe, READ_WRITE, DONT_FREE_CACHE,
0, GINT_TO_POINTER(MCE_SUBMODE_NORMAL));
datapipe_init(&display_state_curr_pipe, READ_ONLY, DONT_FREE_CACHE,
0, GINT_TO_POINTER(MCE_DISPLAY_UNDEF));
Expand Down

0 comments on commit c4d2ffb

Please sign in to comment.