Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Move fbdev control from display plugin to separate mce-fbdev module
Having mce hold open framebuffer device file descriptor during bootup
blocks display from making implicit power cycling while switching ui
components that draw on screen. But since the frame buffer is opened
from display plugin, it happens only after mce core functionality is
already initialized.

Making frame buffer handling be part of core functionality to allow the
device node to be opened earlier.

Also keept the framebuffer device opened also during normal operation
so that mce already has the file descriptor that is needed to keep the
shutdown logo on screen after ui and mce services are terminated.

To give visibility to possible lipstick crashes and switches between
various act dead ui processes, close the file descriptor if compositor
dbus service is terminated eventhought he device is not shutting down.

[mce] Move fbdev control from display plugin to separate mce-fbdev module. Fixes JB#26215
  • Loading branch information
spiiroin committed Feb 10, 2015
1 parent 5a1b388 commit 824acab
Show file tree
Hide file tree
Showing 7 changed files with 447 additions and 256 deletions.
26 changes: 26 additions & 0 deletions .depend
Expand Up @@ -168,6 +168,18 @@ mce-dsme.pic.o:\
mce-log.h\
mce.h\

mce-fbdev.o:\
mce-fbdev.c\
mce-fbdev.h\
mce-hybris.h\
mce-log.h\

mce-fbdev.pic.o:\
mce-fbdev.c\
mce-fbdev.h\
mce-hybris.h\
mce-log.h\

mce-gconf.o:\
mce-gconf.c\
builtin-gconf.h\
Expand Down Expand Up @@ -295,6 +307,7 @@ mce.o:\
mce-conf.h\
mce-dbus.h\
mce-dsme.h\
mce-fbdev.h\
mce-gconf.h\
mce-log.h\
mce-modules.h\
Expand All @@ -315,6 +328,7 @@ mce.pic.o:\
mce-conf.h\
mce-dbus.h\
mce-dsme.h\
mce-fbdev.h\
mce-gconf.h\
mce-log.h\
mce-modules.h\
Expand Down Expand Up @@ -494,6 +508,7 @@ modules/display.o:\
libwakelock.h\
mce-conf.h\
mce-dbus.h\
mce-fbdev.h\
mce-gconf.h\
mce-hybris.h\
mce-io.h\
Expand All @@ -511,6 +526,7 @@ modules/display.pic.o:\
libwakelock.h\
mce-conf.h\
mce-dbus.h\
mce-fbdev.h\
mce-gconf.h\
mce-hybris.h\
mce-io.h\
Expand Down Expand Up @@ -831,6 +847,7 @@ tests/ut/ut_display.o:\
libwakelock.h\
mce-conf.h\
mce-dbus.h\
mce-fbdev.h\
mce-gconf.h\
mce-io.h\
mce-lib.h\
Expand All @@ -850,6 +867,7 @@ tests/ut/ut_display.pic.o:\
libwakelock.h\
mce-conf.h\
mce-dbus.h\
mce-fbdev.h\
mce-gconf.h\
mce-io.h\
mce-lib.h\
Expand All @@ -869,6 +887,7 @@ tests/ut/ut_display_blanking_inhibit.o:\
libwakelock.h\
mce-conf.h\
mce-dbus.h\
mce-fbdev.h\
mce-gconf.h\
mce-hybris.h\
mce-io.h\
Expand All @@ -889,6 +908,7 @@ tests/ut/ut_display_blanking_inhibit.pic.o:\
libwakelock.h\
mce-conf.h\
mce-dbus.h\
mce-fbdev.h\
mce-gconf.h\
mce-hybris.h\
mce-io.h\
Expand All @@ -909,6 +929,7 @@ tests/ut/ut_display_conf.o:\
libwakelock.h\
mce-conf.h\
mce-dbus.h\
mce-fbdev.h\
mce-gconf.h\
mce-hybris.h\
mce-io.h\
Expand All @@ -929,6 +950,7 @@ tests/ut/ut_display_conf.pic.o:\
libwakelock.h\
mce-conf.h\
mce-dbus.h\
mce-fbdev.h\
mce-gconf.h\
mce-hybris.h\
mce-io.h\
Expand All @@ -949,6 +971,7 @@ tests/ut/ut_display_filter.o:\
libwakelock.h\
mce-conf.h\
mce-dbus.h\
mce-fbdev.h\
mce-gconf.h\
mce-hybris.h\
mce-io.h\
Expand All @@ -969,6 +992,7 @@ tests/ut/ut_display_filter.pic.o:\
libwakelock.h\
mce-conf.h\
mce-dbus.h\
mce-fbdev.h\
mce-gconf.h\
mce-hybris.h\
mce-io.h\
Expand All @@ -989,6 +1013,7 @@ tests/ut/ut_display_stm.o:\
libwakelock.h\
mce-conf.h\
mce-dbus.h\
mce-fbdev.h\
mce-gconf.h\
mce-hybris.h\
mce-io.h\
Expand All @@ -1009,6 +1034,7 @@ tests/ut/ut_display_stm.pic.o:\
libwakelock.h\
mce-conf.h\
mce-dbus.h\
mce-fbdev.h\
mce-gconf.h\
mce-hybris.h\
mce-io.h\
Expand Down
3 changes: 3 additions & 0 deletions Makefile
Expand Up @@ -282,6 +282,7 @@ MCE_LDLIBS += $(MCE_PKG_LDLIBS)
MCE_CORE += tklock.c
MCE_CORE += modetransition.c
MCE_CORE += powerkey.c
MCE_CORE += mce-fbdev.c
MCE_CORE += mce-dbus.c
MCE_CORE += mce-dsme.c
MCE_CORE += mce-gconf.c
Expand Down Expand Up @@ -542,6 +543,8 @@ NORMALIZE_USES_SPC =\
filewatcher.c\
filewatcher.h\
libwakelock.h\
mce-fbdev.c\
mce-fbdev.h\
mce-command-line.c\
mce-command-line.h\
mce-hybris.c\
Expand Down

0 comments on commit 824acab

Please sign in to comment.