Skip to content

Commit

Permalink
[tklock] Do not act on initial tklock request datapipe value. JB#44605
Browse files Browse the repository at this point in the history
The tklock_request_pipe does not have a "state". However using output value
tracker for the datapipe causes it to be handled as a state variable. Which
then causes the dummy datapipe default value to be handled as a tklock
change request leading to unnecessary tklock noise on mce startup.

Switch to tracking tklock_request_pipe input values.

Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>
  • Loading branch information
spiiroin committed Mar 8, 2019
1 parent f5deaf8 commit 6538e19
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tklock.c
Expand Up @@ -2219,10 +2219,6 @@ static datapipe_handler_t tklock_datapipe_handlers[] =
.datapipe = &display_state_next_pipe,
.output_cb = tklock_datapipe_display_state_next_cb,
},
{
.datapipe = &tklock_request_pipe,
.output_cb = tklock_datapipe_tklock_request_cb,
},
{
.datapipe = &interaction_expected_pipe,
.output_cb = tklock_datapipe_interaction_expected_cb,
Expand Down Expand Up @@ -2326,6 +2322,10 @@ static datapipe_handler_t tklock_datapipe_handlers[] =
},

// input triggers
{
.datapipe = &tklock_request_pipe,
.input_cb = tklock_datapipe_tklock_request_cb,
},
{
.datapipe = &keypress_event_pipe,
.input_cb = tklock_datapipe_keypress_event_cb,
Expand Down

0 comments on commit 6538e19

Please sign in to comment.