Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[event-input] Enable doubletap emulation by default. Fixes JB#34610
Originally the disable/enable toggle could be used for enabling double
tap detection even in display on states - this is because the feature
was developed primarily with sdk and mouse double clicks in mind.

Later the same detection logic was used for handling double taps that
happen in lpm display states where hw gesture detection is not available.
In these cases the enable/disable setting was in practice ignored.

While fixing the double tap detection during display power off sequence,
I accidentally changed the logic so that it requires
  touch grabbed && setting enabled
instead of the original
  touch grabbed || setting enabled

Since the new behavior actually makes more sense, fix the setting value
so that double tap emulation is enabled by default.
  • Loading branch information
spiiroin committed Mar 21, 2016
1 parent 26a560a commit 16b4970
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion builtin-gconf.c
Expand Up @@ -1427,7 +1427,7 @@ static const setting_t gconf_defaults[] =
// MCE_GCONF_USE_FAKE_DOUBLETAP_PATH @ event-input.h
.key = "/system/osso/dsm/event_input/use_fake_double_tap",
.type = "b",
.def = "false",
.def = "true",
},
#endif
{
Expand Down
2 changes: 1 addition & 1 deletion event-input.c
Expand Up @@ -1457,7 +1457,7 @@ evin_evdevtype_from_info(evin_evdevinfo_t *info)
#ifdef ENABLE_DOUBLETAP_EMULATION

/** Fake doubletap policy */
static gboolean fake_evin_doubletap_enabled = FALSE;
static gboolean fake_evin_doubletap_enabled = TRUE;

/** GConf callback ID for fake doubletap policy changes */
static guint fake_evin_doubletap_id = 0;
Expand Down

0 comments on commit 16b4970

Please sign in to comment.