Skip to content

Commit

Permalink
Remove test that expects wrong
Browse files Browse the repository at this point in the history
Creating notification with replacementId creates a notification
even if there was no previous one.
  • Loading branch information
pvuorela committed Dec 12, 2017
1 parent 95c79c6 commit 79a186a
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 14 deletions.
13 changes: 0 additions & 13 deletions tests/ut_notificationmanager/ut_notificationmanager.cpp
Expand Up @@ -74,19 +74,6 @@ void Ut_NotificationManager::testCapabilities()
QCOMPARE((bool)capabilities.contains(LipstickNotification::HINT_MAX_CONTENT_LINES), true);
}

void Ut_NotificationManager::testUpdatingInexistingNotification()
{
NotificationManager *manager = NotificationManager::instance();
QSignalSpy modifiedSpy(manager, SIGNAL(notificationModified(uint)));
QSignalSpy addedSpy(manager, SIGNAL(notificationAdded(uint)));
uint id = manager->Notify("appName", 1, "appIcon", "summary", "body", QStringList(), QVariantHash(), 1);
QCOMPARE(id, (uint)0);
QTest::qWait(1100);
QCOMPARE(modifiedSpy.count(), 0);
QCOMPARE(addedSpy.count(), 0);
QCOMPARE(qSqlQueryPrepare.count(), 0);
}

void Ut_NotificationManager::testRemovingInexistingNotification()
{
NotificationManager *manager = NotificationManager::instance();
Expand Down
1 change: 0 additions & 1 deletion tests/ut_notificationmanager/ut_notificationmanager.h
Expand Up @@ -26,7 +26,6 @@ private slots:
void cleanup();
void testManagerIsSingleton();
void testCapabilities();
void testUpdatingInexistingNotification();
void testRemovingInexistingNotification();
void testServerInformation();
void testModifyingCategoryDefinitionUpdatesNotifications();
Expand Down

0 comments on commit 79a186a

Please sign in to comment.