Skip to content

Commit

Permalink
Remove test that doesn't reflect reality anymore and isn't too useful
Browse files Browse the repository at this point in the history
removeNotification has now lambda expression. Test assuming
internal behavior and doesn't provide much.
  • Loading branch information
pvuorela committed Jan 17, 2018
1 parent c49ca59 commit 7629987
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 9 deletions.
Expand Up @@ -214,14 +214,6 @@ void Ut_NotificationPreviewPresenter::cleanup()
gQmDisplayStateStub->stubReset();
}

void Ut_NotificationPreviewPresenter::testSignalConnections()
{
NotificationPreviewPresenter presenter(screenLock, deviceLock);
QCOMPARE(disconnect(NotificationManager::instance(), SIGNAL(notificationAdded(uint)), &presenter, SLOT(updateNotification(uint))), true);
QCOMPARE(disconnect(NotificationManager::instance(), SIGNAL(notificationRemoved(uint)), &presenter, SLOT(removeNotification(uint))), true);
QCOMPARE(disconnect(&presenter, SIGNAL(notificationPresented(uint)), presenter.m_notificationFeedbackPlayer, SLOT(addNotification(uint))), true);
}

void Ut_NotificationPreviewPresenter::testAddNotificationWhenWindowNotOpen()
{
NotificationPreviewPresenter presenter(screenLock, deviceLock);
Expand Down
Expand Up @@ -33,7 +33,6 @@ private slots:
void initTestCase();
void init();
void cleanup();
void testSignalConnections();
void testAddNotificationWhenWindowNotOpen();
void testAddNotificationWhenWindowAlreadyOpen();
void testUpdateNotification();
Expand Down

0 comments on commit 7629987

Please sign in to comment.