Skip to content

Commit

Permalink
[usb-moded-qt5] Ignore reply to com.meego.usb_moded.set_mode() method…
Browse files Browse the repository at this point in the history
… call. JB#42756

The set_mode() method call merely initiates mode transition, and a separate
signal will be broadcast when/if it finishes.

Ignore set_mode() reply value, but leave the pending call handler in place
as it still has use from debugging point of view.

Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>
  • Loading branch information
spiiroin committed Aug 31, 2018
1 parent 22a12aa commit cfea6ec
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/qusbmoded.cpp
Expand Up @@ -398,10 +398,10 @@ void QUsbModed::onSetModeFinished(QDBusPendingCallWatcher* aCall)
if (!reply.isError()) {
QString mode = reply.value();
DEBUG_(mode);
if (iPrivate->iCurrentMode != mode) {
iPrivate->iCurrentMode = mode;
Q_EMIT currentModeChanged();
}
// Note: Getting a reply does not indicate mode change.
// Even accepted requests could get translated to
// something else (e.g. charging only) if there
// are problems during mode activation
} else {
DEBUG_(reply.error());
}
Expand Down

0 comments on commit cfea6ec

Please sign in to comment.