{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":358114852,"defaultBranch":"master","name":"libngf-qt","ownerLogin":"sailfishos","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2021-04-15T03:26:51.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/6198659?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1701434113.0","currentOid":""},"activityList":{"items":[{"before":"ec6f293d4751788908984150a34c90c7524368d1","after":"00577c722cb993e325aacd6f5b9fe6b8da9d29b6","ref":"refs/heads/master","pushedAt":"2023-12-01T12:34:50.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"pvuorela","name":"Pekka Vuorela","path":"/pvuorela","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2478615?s=80&v=4"},"commit":{"message":"Merge pull request #9 from sailfishos/state_robustness\n\n[libngf-qt] Make multiple state changes more robust. JB#61050","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2018858444\" data-permission-text=\"Title is private\" data-url=\"https://github.com/sailfishos/libngf-qt/issues/9\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/sailfishos/libngf-qt/pull/9/hovercard\" href=\"https://github.com/sailfishos/libngf-qt/pull/9\">#9</a> from sailfishos/state_robustness"}},{"before":null,"after":"8af5b76c73757a443dff725cb2ec150f27fc1331","ref":"refs/heads/state_robustness","pushedAt":"2023-11-30T14:58:49.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"pvuorela","name":"Pekka Vuorela","path":"/pvuorela","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2478615?s=80&v=4"},"commit":{"message":"[libngf-qt] Make multiple state changes more robust. JB#61050\n\nIf calling e.g. stop() twice both of those request were passed to ngfd\nwhich at later moment didn't anymore have the event with such id,\ngot confused and issued warnings.\n\nSome details adjusted:\n- State change method bool return values are defined as\n\"False if no connection to NGF daemon\", so making them behave as such.\nThough didn't find any place interested in the return values.\n- Some methods renamed a bit to match better what they do, e.g. set\nor request something.\n- Splitted the pending state change requested to its own member variable\nto keep it simpler. Active state is now what's reported active by the\nserver and wanted state is what's requested the last time from the server,\nprotecting against requesting same thing many times.","shortMessageHtmlLink":"[libngf-qt] Make multiple state changes more robust. JB#61050"}},{"before":"ea66947448a5f072693aec1c4027d84a65bdbb24","after":"ec6f293d4751788908984150a34c90c7524368d1","ref":"refs/heads/master","pushedAt":"2023-05-02T10:52:43.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"pvuorela","name":"Pekka Vuorela","path":"/pvuorela","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2478615?s=80&v=4"},"commit":{"message":"Merge pull request #8 from sailfishos/no_warning_on_fail\n\n[libngf-qt] Don't warn on play failed signal. Fixes JB#60695","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1691925920\" data-permission-text=\"Title is private\" data-url=\"https://github.com/sailfishos/libngf-qt/issues/8\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/sailfishos/libngf-qt/pull/8/hovercard\" href=\"https://github.com/sailfishos/libngf-qt/pull/8\">#8</a> from sailfishos/no_warning_on_fail"}},{"before":"e62f739c45a410c26e512490b37eebe602d84a1d","after":"ea66947448a5f072693aec1c4027d84a65bdbb24","ref":"refs/heads/master","pushedAt":"2023-05-02T10:52:25.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"pvuorela","name":"Pekka Vuorela","path":"/pvuorela","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2478615?s=80&v=4"},"commit":{"message":"Merge pull request #7 from sailfishos/non_touch_vibra\n\n[libngf-qt] Use different feedback event for non-touch haptics. JB#60638","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1688745458\" data-permission-text=\"Title is private\" data-url=\"https://github.com/sailfishos/libngf-qt/issues/7\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/sailfishos/libngf-qt/pull/7/hovercard\" href=\"https://github.com/sailfishos/libngf-qt/pull/7\">#7</a> from sailfishos/non_touch_vibra"}},{"before":null,"after":"7410074e2bc32092d35e402745acdde97e4f8901","ref":"refs/heads/no_warning_on_fail","pushedAt":"2023-05-02T07:33:48.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"pvuorela","name":"Pekka Vuorela","path":"/pvuorela","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2478615?s=80&v=4"},"commit":{"message":"[libngf-qt] Don't warn on play failed signal. Fixes JB#60695\n\nThe failed signal can come from just settings having haptic feedback\nturned off. On such case we shouldn't constantly spam the journal.\n\nCould be debated whether haptic settings should result in play request\nfailing vs just silently ignoring it, but at the moment ngfd plugin\ninterface explicitly defines it this way.","shortMessageHtmlLink":"[libngf-qt] Don't warn on play failed signal. Fixes JB#60695"}},{"before":null,"after":"8b380ff7c81817071d4e8a029ebc7fd68efcf7c3","ref":"refs/heads/non_touch_vibra","pushedAt":"2023-04-28T15:23:25.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"pvuorela","name":"Pekka Vuorela","path":"/pvuorela","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2478615?s=80&v=4"},"commit":{"message":"[libngf-qt] Use different feedback event for non-touch haptics. JB#60638\n\nWe have different settings for vibra on/off totally, or on/off only\nfor display touch events. Latter used by the theme effects, former\nones going this path.","shortMessageHtmlLink":"[libngf-qt] Use different feedback event for non-touch haptics. JB#60638"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADvUPv9gA","startCursor":null,"endCursor":null}},"title":"Activity · sailfishos/libngf-qt"}