Skip to content
This repository has been archived by the owner on Sep 4, 2021. It is now read-only.

Commit

Permalink
[libcontact] Fix recursive resolve never finishing. Contributes to JB…
Browse files Browse the repository at this point in the history
…#42702

ResolveListener::addressResolved() implementations can do silly things
like start resolving for something it just received information for.
That ended up new request being filtered out as duplicate request
but then never getting response with addressResolved.

Above case with libcommhistory / RecentContactsModel.
  • Loading branch information
pvuorela committed Aug 30, 2018
1 parent 96361fd commit 84b004f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/seasidecache.cpp
Expand Up @@ -2909,9 +2909,9 @@ void SeasideCache::addressRequestStateChanged(QContactAbstractRequest::State sta

m_unknownAddresses.append(data);
}
m_pendingResolve.remove(data);
data.listener->addressResolved(data.first, data.second, item);
delete it.key();
m_pendingResolve.remove(data);
m_resolveAddresses.erase(it);
}

Expand Down

0 comments on commit 84b004f

Please sign in to comment.