Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sailfishos/libcommhistory
base: eaa34648d751cbf5fa5c802c93b0a3d7f4b5dfef
Choose a base ref
...
head repository: sailfishos/libcommhistory
compare: 0f8702a8d644edc8c4dce62a4e329cb72dd01b18
Choose a head ref
  • 3 commits
  • 4 files changed
  • 2 contributors

Commits on Jan 29, 2020

  1. [libcommhistory] Always use matchesPhoneNumber for phone numbers. Con…

    …tributes to JB#38835
    Timur Kristóf committed Jan 29, 2020
    Copy the full SHA
    713fede View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2020

  1. [libcommhistory] Use libphonenumber for matching. Contributes to JB#3…

    …8835
    
    Examples of solved false positive matches:
    "+36 20 123 4567" and "+36 30 123 4567" were matched incorrectly.
    "+36 20 123 4567" and "+44 20 123 4567" were matched incorrectly.
    
    Examples of local and IDD numbers that still work:
    "+36 20 123 4567" still matches "06 20 123 4567" (local)
    "+36 20 123 4567" still matches "00 36 70 381 0581" (IID)
    
    Examples of remaining false positives:
    "06 20 123 4567" is a false positive match of "+1 0620 123 4567"
    "00 36 20 123 4567" is a false positive match of "+1 00 36 20 123 4567"
    
    We deem that the remaining false positives are unlikely enough that
    they don't matter in practice. If this becomes relevant, we will need
    to make it possible to pass a region code to the matching algorithm.
    Timur Kristóf committed Feb 4, 2020
    Copy the full SHA
    c24308d View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2020

  1. Merge branch 'jb38835-numbermatching' into 'master'

    Phone number matching
    
    See merge request mer-core/libcommhistory!32
    Venemo committed Feb 7, 2020
    Copy the full SHA
    0f8702a View commit details
    Browse the repository at this point in the history