1. 17 Dec, 2020 3 commits
  2. 16 Dec, 2020 2 commits
  3. 03 Dec, 2020 1 commit
  4. 02 Dec, 2020 1 commit
    • Bea Lam's avatar
      [libcommhistory] Consolidate contact/recipient event models and fix unit tests. JB#48263 · 5566f3c1
      Bea Lam authored
      Remove SingleContactEventModel; move its features into
      RecipientEventModel, which now accepts either recipients or a contact
      id as the event filter. We can do without the class split for
      filtering events by saved vs non-saved contacts, and combining these
      into a single model simplifies the code base.
      
      RecipientEventModel can resolve contacts into recipients and also
      recipients into contacts (for e.g. when a recipient matches a contact
      that has multiple phone numbers). Instead of having multiple getEvents()
      functions, it now has setRecipients() functions to set the filter,
      then getEvents() can be called to execute the query.
      
      Remove ContactEventModel, and add DeclarativeRecipientEventModel as
      a QML wrapper around RecipientEventModel.
      
      Fix various issues in the unit tests where contact creation/editing
      were failing as they were operating on aggregates (which are read-only)
      rather than local constituents (which are writable). The unit tests in
      SingleContactEventModelTest have been moved into
      RecipientEventModelTest.
      
      The unit tests now modify the main contacts database directly instead
      of creating a separate test database. This avoids test failures where
      the tests are accessing a QContactManager instance that is different
      from the one accessed via the SeasideCache in the library (to resolve
      contacts, for example).
      5566f3c1
  5. 30 Nov, 2020 2 commits
  6. 25 Nov, 2020 1 commit
  7. 20 Nov, 2020 3 commits
  8. 18 Nov, 2020 2 commits
  9. 10 Nov, 2020 2 commits
  10. 25 Sep, 2020 1 commit
  11. 23 Sep, 2020 1 commit
  12. 15 Sep, 2020 3 commits
  13. 11 Sep, 2020 2 commits
  14. 26 Jun, 2020 2 commits
  15. 08 Jun, 2020 1 commit
  16. 29 May, 2020 1 commit
  17. 06 May, 2020 1 commit
  18. 05 May, 2020 1 commit
  19. 16 Apr, 2020 1 commit
  20. 14 Apr, 2020 1 commit
  21. 07 Feb, 2020 1 commit
  22. 04 Feb, 2020 1 commit
    • Timur Kristóf's avatar
      [libcommhistory] Use libphonenumber for matching. Contributes to JB#38835 · c24308df
      Timur Kristóf authored
      Examples of solved false positive matches:
      "+36 20 123 4567" and "+36 30 123 4567" were matched incorrectly.
      "+36 20 123 4567" and "+44 20 123 4567" were matched incorrectly.
      
      Examples of local and IDD numbers that still work:
      "+36 20 123 4567" still matches "06 20 123 4567" (local)
      "+36 20 123 4567" still matches "00 36 70 381 0581" (IID)
      
      Examples of remaining false positives:
      "06 20 123 4567" is a false positive match of "+1 0620 123 4567"
      "00 36 20 123 4567" is a false positive match of "+1 00 36 20 123 4567"
      
      We deem that the remaining false positives are unlikely enough that
      they don't matter in practice. If this becomes relevant, we will need
      to make it possible to pass a region code to the matching algorithm.
      c24308df
  23. 29 Jan, 2020 1 commit
  24. 26 Nov, 2019 3 commits
  25. 15 Nov, 2019 1 commit
  26. 25 Oct, 2019 1 commit