Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in
K
kf5-calendarcore
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • mer-core
  • kf5-calendarcore
  • Merge Requests
  • !2

Merged
Opened Jan 04, 2021 by Damien Caliste@dcaliste
  • Report abuse
Report abuse

[kf5-calendarcore] Correct deletion of occurrences not using the recurrenceId. Contributes to JB#52656

  • Overview 11
  • Commits 1
  • Changes 4

This corresponds to the upstream MR.

@blam, this is a rewrite of your patch fixing the issue in deleteIncidenceInstances(). Looking closer to the deleteIncidence() function it is calling, I've noticed that this delete function is misbehaving for occurrences because it is not paying attention to the recurrenceId... I've taken the liberty to rewrite your patch, because both issues while being distinct are related together. I hope you don't mind. I've added a test also for upstream. Let see what they say upstream about this. I'll rework the patch here after it will be accepted with or without revisions.

@chriadam, for your information, some hickups of the transition...

Edited Jan 12, 2021 by chriadam
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: mer-core/kf5-calendarcore!2

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.