From 6cf56f985fa6370950cdb23708d84718fb8a1a53 Mon Sep 17 00:00:00 2001 From: Andrew Branson Date: Wed, 11 Dec 2019 11:27:48 +0100 Subject: [PATCH] codec error handling: Provide friendly name in error message. [error] Provide friendly name for missing codec in error message. JB#47099 --- ...vide-friendly-name-for-missing-codec.patch | 26 +++++++++++++++++++ rpm/gst-plugins-base.spec | 2 ++ 2 files changed, 28 insertions(+) create mode 100644 rpm/0003-Provide-friendly-name-for-missing-codec.patch diff --git a/rpm/0003-Provide-friendly-name-for-missing-codec.patch b/rpm/0003-Provide-friendly-name-for-missing-codec.patch new file mode 100644 index 0000000..eb188b2 --- /dev/null +++ b/rpm/0003-Provide-friendly-name-for-missing-codec.patch @@ -0,0 +1,26 @@ +From da2f70445e98468bb4a28f9a7f570894ac5b6966 Wed, 11 Dec 2019 11:25:59 +0100 +From: Andrew Branson +Date: Wed, 11 Dec 2019 11:25:29 +0100 +Subject: [PATCH] [error] Provide friendly name for missing codec in error message. JB#47099 + +diff --git a/gst/playback/gsturidecodebin.c b/gst/playback/gsturidecodebin.c +index f19f69a..059b30a 100644 +--- a/gst/playback/gsturidecodebin.c ++++ b/gst/playback/gsturidecodebin.c +@@ -38,6 +38,7 @@ + #include + #include + #include ++#include + + #include "gstplay-enum.h" + #include "gstrawcaps.h" +@@ -918,7 +919,7 @@ + + capsstr = gst_caps_to_string (caps); + GST_ELEMENT_WARNING (decoder, STREAM, CODEC_NOT_FOUND, +- (_("No decoder available for type \'%s\'."), capsstr), (NULL)); ++ (gst_pb_utils_get_codec_description(caps)), (NULL)); + g_free (capsstr); + } + diff --git a/rpm/gst-plugins-base.spec b/rpm/gst-plugins-base.spec index 5591006..bfb93ed 100644 --- a/rpm/gst-plugins-base.spec +++ b/rpm/gst-plugins-base.spec @@ -13,6 +13,7 @@ Source: http://gstreamer.freedesktop.org/src/gst-plugins-base/gstreamer1 Patch0: 0000-Move-encodebin-sources-to-encodebasebin.patch Patch1: 0001-encodebin-Split-implementation-into-a-base-class.patch Patch2: 0002-splitencodebin-Add-new-element.patch +Patch3: 0003-Provide-friendly-name-for-missing-codec.patch %define sonamever %(echo %{version} | cut -d '+' -f 1) @@ -66,6 +67,7 @@ GStreamer Plugins Base library applications %patch0 -p1 %patch1 -p1 %patch2 -p1 +%patch3 -p1 %build