Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[glib] Replace g_critical in g_source_remove with g_warning. Contribu…
…tes to JB#35380 glib 2.39 and later calls g_critical from g_source_remove() if it's called with invalid source id. Even though it's a programming error, in most cases it's not fatal.
- Loading branch information
Showing
2 changed files
with
16 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
diff --git a/glib/gmain.c b/glib/gmain.c | ||
index 29ccee0..79e4fa6 100644 | ||
--- a/glib/gmain.c | ||
+++ b/glib/gmain.c | ||
@@ -2281,7 +2281,7 @@ g_source_remove (guint tag) | ||
if (source) | ||
g_source_destroy (source); | ||
else | ||
- g_critical ("Source ID %u was not found when attempting to remove it", tag); | ||
+ g_warning ("Source ID %u was not found when attempting to remove it", tag); | ||
|
||
return source != NULL; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters