Skip to content

Commit

Permalink
Merge branch 'jb51300' into 'master'
Browse files Browse the repository at this point in the history
[sailfish][gecko] Always disable logging for RELEASE_OR_BETA. Fixes JB#51300

See merge request mer-core/gecko-dev!197
  • Loading branch information
Andrew Branson committed Dec 2, 2020
2 parents f3a944f + 1427a04 commit c8455d0
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 0 deletions.
21 changes: 21 additions & 0 deletions rpm/0052-sailfishos-gecko-Remove-android-define-from-logging.patch
@@ -0,0 +1,21 @@
From 5b8349a7a351c80a075eaea17e9ebfd8992b009b Wed, 2 Dec 2020 12:15:39 +0100
From: Andrew Branson <andrew.branson@jolla.com>
Date: Wed, 2 Dec 2020 12:14:54 +0100
Subject: [PATCH] [sailfishos][gecko] Always disable logging for RELEASE_OR_BETA.

Upstream always enables logging except on Android when RELEASE_OR_BETA is defined.
This patch removes the Android condition so our releases disable logging too.

diff --git a/xpcom/base/Logging.h b/xpcom/base/Logging.h
index a35318c..08e1876 100644
--- a/xpcom/base/Logging.h
+++ b/xpcom/base/Logging.h
@@ -24,7 +24,7 @@
// devices, we've chosen to leave logging enabled on desktop, but disabled on
// Android. Given that logging can still be useful for development purposes,
// however, we leave logging enabled on Android developer builds.
-#if !defined(ANDROID) || !defined(RELEASE_OR_BETA)
+#if !defined(RELEASE_OR_BETA)
#define MOZ_LOGGING_ENABLED 1
#else
#define MOZ_LOGGING_ENABLED 0
1 change: 1 addition & 0 deletions rpm/xulrunner-qt5.spec
Expand Up @@ -94,6 +94,7 @@ Patch48: 0048-sailfishos-backport-Enable-MOZ_GECKO_PROFILER-on-And.patch
Patch49: 0049-sailfishos-backport-Implement-DWARF-stack-walker-for.patch
Patch50: 0050-sailfishos-gecko-Buffer-when-the-video-decoder-lags-.patch
Patch51: 0051-sailfishos-gecko-Make-button-hit-testing-similar-to-.patch
Patch52: 0052-sailfishos-gecko-Remove-android-define-from-logging.patch

BuildRequires: rust
BuildRequires: rust-std-static
Expand Down

0 comments on commit c8455d0

Please sign in to comment.