Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Remove some unnecessary/dead code from TabChild.
1. The HasValidInnerSize function and mHasValidInnerSize variable are
   already defined in TabChild's base class. Since the purpose for both
   versions is exactly the same remove embedlite's unnecessary override.
2. The TabChild::mLastSubFrameMetrics is not used anywhere in the code.
  • Loading branch information
tworaz committed Jun 12, 2015
1 parent 55b0fd5 commit a4eddcd
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
7 changes: 0 additions & 7 deletions embedding/embedlite/utils/TabChildHelper.cpp
Expand Up @@ -51,7 +51,6 @@ static bool sPostAZPCAsJsonViewport(false);

TabChildHelper::TabChildHelper(EmbedLiteViewChildIface* aView)
: mView(aView)
, mHasValidInnerSize(false)
{
LOGT();

Expand Down Expand Up @@ -201,12 +200,6 @@ TabChildHelper::InitTabChildGlobal()
return true;
}

bool
TabChildHelper::HasValidInnerSize()
{
return mHasValidInnerSize;
}

NS_IMETHODIMP
TabChildHelper::Observe(nsISupports* aSubject,
const char* aTopic,
Expand Down
3 changes: 0 additions & 3 deletions embedding/embedlite/utils/TabChildHelper.h
Expand Up @@ -70,7 +70,6 @@ class TabChildHelper : public mozilla::dom::TabChildBase,
bool ConvertMutiTouchInputToEvent(const mozilla::MultiTouchInput& aData,
WidgetTouchEvent& aEvent);
void CancelTapTracking();
bool HasValidInnerSize();

private:
bool InitTabChildGlobal();
Expand All @@ -82,8 +81,6 @@ class TabChildHelper : public mozilla::dom::TabChildBase,
friend class EmbedLiteViewChildIface;
friend class EmbedLiteViewBaseChild;
EmbedLiteViewChildIface* mView;
mozilla::layers::FrameMetrics mLastSubFrameMetrics;
bool mHasValidInnerSize;
};

}
Expand Down

0 comments on commit a4eddcd

Please sign in to comment.