Skip to content

Commit

Permalink
Bug 1256604 - Remove toolkit/content/Makefile.in and move setting CXX…
Browse files Browse the repository at this point in the history
…FLAGS for buildconfig.html to moz.build r=mshal

MozReview-Commit-ID: FZ6MTVAWSZa

--HG--
extra : rebase_source : ed71a72ec0430aed072321b0151b9efd229f940d
  • Loading branch information
chmanchester committed Nov 9, 2017
1 parent 1f2b7dc commit 4894ea0
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 14 deletions.
3 changes: 1 addition & 2 deletions config/faster/rules.mk
Expand Up @@ -59,8 +59,7 @@ endif
.PHONY: FORCE

# Extra define to trigger some workarounds. We should strive to limit the
# use of those. As of writing the only ones are in
# toolkit/content/buildconfig.html and browser/locales/jar.mn.
# use of those. As of writing the only one is in browser/locales/jar.mn.
ACDEFINES += -DBUILD_FASTER

# Files under the faster/ sub-directory, however, are not meant to use the
Expand Down
9 changes: 0 additions & 9 deletions toolkit/content/Makefile.in

This file was deleted.

4 changes: 1 addition & 3 deletions toolkit/content/buildconfig.html
Expand Up @@ -50,9 +50,7 @@ <h2>Build tools</h2>
<tr>
<td>@CXX@</td>
<td>@CC_VERSION@</td>
#ifndef BUILD_FASTER
<td>@CXXFLAGS@ @CPPFLAGS@</td>
#endif
<td>@CXXFLAGS@</td>
</tr>
</tbody>
</table>
Expand Down
6 changes: 6 additions & 0 deletions toolkit/content/moz.build
Expand Up @@ -11,6 +11,12 @@ for var in ('target', 'MOZ_CONFIGURE_OPTIONS', 'CC', 'CC_VERSION', 'CXX'):

DEFINES['CFLAGS'] = ' '.join(CONFIG['OS_CFLAGS'])

cxx_flags = []
for var in ('OS_CPPFLAGS', 'OS_CXXFLAGS', 'DEBUG', 'OPTIMIZE', 'FRAMEPTR'):
cxx_flags += COMPILE_FLAGS.get(var, [])

DEFINES['CXXFLAGS'] = ' '.join(cxx_flags)

if CONFIG['OS_TARGET'] == 'Android':
DEFINES['ANDROID_PACKAGE_NAME'] = CONFIG['ANDROID_PACKAGE_NAME']
DEFINES['MOZ_USE_LIBCXX'] = True
Expand Down

0 comments on commit 4894ea0

Please sign in to comment.