[embedlite] Passing arguments to InitGeckoWindow by value. Fixes JB#4…

…9916
sailfishos · May 19, 2020 · 4560773 · 4560773
1 parent d4b0904
commit 4560773
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/embedshared/EmbedLiteViewBaseChild.cpp b/embedshared/EmbedLiteViewBaseChild.cpp
@@ -112,7 +112,7 @@ EmbedLiteViewBaseChild::EmbedLiteViewBaseChild(const uint32_t& aWindowId, const
   mWindow = EmbedLiteAppBaseChild::GetInstance()->GetWindowByID(aWindowId);
   MOZ_ASSERT(mWindow != nullptr);
 
-  MessageLoop::current()->PostTask(NewRunnableMethod<const uint32_t&, const bool &>
+  MessageLoop::current()->PostTask(NewRunnableMethod<const uint32_t, const bool>
                                    (this,
                                     &EmbedLiteViewBaseChild::InitGeckoWindow,
                                     aParentId,
@@ -161,7 +161,7 @@ bool EmbedLiteViewBaseChild::RecvDestroy()
 }
 
 void
-EmbedLiteViewBaseChild::InitGeckoWindow(const uint32_t& parentId, const bool& isPrivateWindow)
+EmbedLiteViewBaseChild::InitGeckoWindow(const uint32_t parentId, const bool isPrivateWindow)
 {
   if (!mWindow) {
     LOGT("Init called for already destroyed object");

diff --git a/embedshared/EmbedLiteViewBaseChild.h b/embedshared/EmbedLiteViewBaseChild.h
@@ -211,7 +211,7 @@ class EmbedLiteViewBaseChild : public PEmbedLiteViewChild,
   friend class EmbedLiteAppThreadChild;
   friend class EmbedLiteAppBaseChild;
 
-  void InitGeckoWindow(const uint32_t& parentId, const bool& isPrivateWindow);
+  void InitGeckoWindow(const uint32_t parentId, const bool isPrivateWindow);
   void InitEvent(WidgetGUIEvent& event, nsIntPoint* aPoint = nullptr);
 
   uint32_t mId;