Bug 1204134 (attempt 2) - Fix and disallow warnings in config/moz.bui…

…ld. r=glandium.
sailfishos · Sep 16, 2015 · 25ef63f · 25ef63f
1 parent f0aa7a8
commit 25ef63f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/config/moz.build b/config/moz.build
@@ -43,9 +43,6 @@ PYTHON_UNIT_TESTS += [
 if CONFIG['GNU_CC'] and CONFIG['MOZ_OPTIMIZE']:
     CFLAGS += ['-O3']
 
-# XXX: We should fix these warnings.
-ALLOW_COMPILER_WARNINGS = True
-
 HOST_DEFINES = {
     'UNICODE': True,
     '_UNICODE': True,

diff --git a/config/pathsub.c b/config/pathsub.c
@@ -34,7 +34,7 @@
 char *program;
 
 void
-fail(char *format, ...)
+fail(const char *format, ...)
 {
     int error;
     va_list ap;
@@ -143,7 +143,7 @@ xbasename(char *path)
 }
 
 void
-xchdir(char *dir)
+xchdir(const char *dir)
 {
     if (chdir(dir) < 0)
 	fail("cannot change directory to %s", dir);

diff --git a/config/pathsub.h b/config/pathsub.h
@@ -25,13 +25,13 @@
 
 extern char *program;
 
-extern void fail(char *format, ...);
+extern void fail(const char *format, ...);
 extern char *getcomponent(char *path, char *name);
 extern char *ino2name(ino_t ino);
 extern void *xmalloc(size_t size);
 extern char *xstrdup(char *s);
 extern char *xbasename(char *path);
-extern void xchdir(char *dir);
+extern void xchdir(const char *dir);
 
 /* Relate absolute pathnames from and to returning the result in outpath. */
 extern int relatepaths(char *from, char *to, char *outpath);