Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sailfishos/dsme
base: 070fc0f87d3704424a61c5c1d547aa057183408c
Choose a base ref
...
head repository: sailfishos/dsme
compare: c8b32b6aebcfef6a3e33b62b344d77b5f884582e
Choose a head ref
  • 7 commits
  • 13 files changed
  • 2 contributors

Commits on Jan 5, 2021

  1. [dsme] Enablers for privileged client checking

    Add utility functions for checking whether a process should be
    considered privileged.
    
    Add predicate function for checking whether dispatched dsme
    message originates from privileged client (or dsme itself).
    
    Make it possible to mark D-Bus method calls served by dsme as
    privileged and send access denied error reply if such method
    is called from an unpriviliged client.
    
    Do not trigger vibration feedback when shutdown/reboot requests
    are received, so that vibration occurs only when such requests
    are accepted.
    
    Move legacy aegis credential check delay in dsmetool so that it
    happens on disconnect rather than on connect. While such delay
    is not necessary anymore, having it occur just before exit allows
    dsme side diagnostic logging to have access to client details.
    
    Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
    spiiroin committed Jan 5, 2021
    Copy the full SHA
    e74970c View commit details
    Browse the repository at this point in the history
  2. [abootsettings] Only privileged clients can set lock state. Fixes JB#…

    …52494
    
    Mark set_locked method call as privileged.
    
    Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
    spiiroin committed Jan 5, 2021
    Copy the full SHA
    8774bb8 View commit details
    Browse the repository at this point in the history
  3. [state] Reject reboot requests from unprivileged endpoints. JB#38609

    Before accepting requests that can cause shutdown or reboot, check
    that they originate from privileged client (or dsme itself).
    
    Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
    spiiroin committed Jan 5, 2021
    Copy the full SHA
    603acfa View commit details
    Browse the repository at this point in the history
  4. [dbusproxy] Only privileged clients can reboot device. Fixes JB#38609

    Mark shutdown, reboot and powerup method calls as privileged.
    
    Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
    spiiroin committed Jan 5, 2021
    Copy the full SHA
    a3efbc2 View commit details
    Browse the repository at this point in the history
  5. [dbusproxy] Set reply message when method call is successfully handled

    Method call message dispatching logic assumes that something went wrong
    if handler callback does not provide reply message and sends a generic
    error reply. Some handlers never fill in reply and this causes false
    negative error replies to be sent to clients.
    
    Return empty reply message even if handler does not have any specific
    value to return to avoid confusion at client end.
    
    Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
    spiiroin committed Jan 5, 2021
    Copy the full SHA
    24832d3 View commit details
    Browse the repository at this point in the history
  6. [tests] Fix autotest build

    Need to link with utility object, and that in turn contains encrypted home
    partition checks that need libcryptsetup.
    
    Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
    spiiroin committed Jan 5, 2021
    Copy the full SHA
    96a8b31 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2021

  1. Merge branch 'jb52494_privileged_dbus' into 'master'

    Allow only privileged clients to reboot device / modify aboot settings
    
    See merge request mer-core/dsme!46
    spiiroin committed Jan 20, 2021
    Copy the full SHA
    c8b32b6 View commit details
    Browse the repository at this point in the history