Skip to content

Commit

Permalink
[dsme] Use dbus-gmain instead of dbus-glib
Browse files Browse the repository at this point in the history
Signed-off-by: Björn Bidar <bjorn.bidar@jolla.com>
  • Loading branch information
Thaodan committed Oct 6, 2020
1 parent ad9a87a commit b0ef974
Show file tree
Hide file tree
Showing 8 changed files with 27 additions and 26 deletions.
2 changes: 1 addition & 1 deletion Makefile.am
@@ -1 +1 @@
SUBDIRS = dsme modules util test tests getbootstate
SUBDIRS = dbus-gmain dsme modules util test tests getbootstate
9 changes: 5 additions & 4 deletions configure.ac
@@ -1,7 +1,8 @@
# Package name and version
AC_INIT(dsme, 0.81.4)

AM_INIT_AUTOMAKE
AM_INIT_AUTOMAKE([foreign subdir-objects])
AM_EXTRA_RECURSIVE_TARGETS([dbus-gmain])

AC_PREREQ([2.61])
AC_CONFIG_SRCDIR([dsme/dsme-wdd-wd.c])
Expand Down Expand Up @@ -204,9 +205,8 @@ AM_PROG_CC_C_O()

# Pkgconf checks
PKG_CHECK_MODULES(LIBCRYPTSETUP, libcryptsetup)
PKG_CHECK_MODULES(GLIB, glib-2.0)
PKG_CHECK_MODULES(DBUS, dbus-1)
PKG_CHECK_MODULES(DBUSGLIB, dbus-glib-1)
PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.40)
PKG_CHECK_MODULES(DBUS, dbus-1 >= 1.8)
PKG_CHECK_MODULES(MCE_DEV, mce,
[],
AC_MSG_ERROR(Development files for mce are missing. Install mce-headers / mce-dev.))
Expand Down Expand Up @@ -252,6 +252,7 @@ AC_CHECK_FUNCS([atexit clock_gettime dup2 ftw64 gettimeofday inet_ntoa memmove

# Create files
AC_CONFIG_FILES([Makefile
dbus-gmain/Makefile
dsme/Makefile
modules/Makefile
util/Makefile
Expand Down
19 changes: 12 additions & 7 deletions modules/Makefile.am
Expand Up @@ -3,7 +3,7 @@
#
AM_CFLAGS = $(C_GENFLAGS) $(C_OPTFLAGS) -fPIC
AM_LDFLAGS = -pthread -module -avoid-version -shared
AM_CPPFLAGS = $(CPP_GENFLAGS)
AM_CPPFLAGS = $(CPP_GENFLAGS) -I$(top_srcdir)
ACLOCAL_AMFLAGS = -I m4

pkglib_LTLIBRARIES = startup.la \
Expand Down Expand Up @@ -90,7 +90,8 @@ state_la_LIBADD =
if WANT_VIBRA_FEEDBACK
state_la_SOURCES += vibrafeedback.c vibrafeedback.h
state_la_CFLAGS += $(GLIB_CFLAGS) $(LIBNGF_CFLAGS)
state_la_LIBADD += $(GLIB_LIBS) $(LIBNGF_LIBS)
state_la_LIBADD += $(GLIB_LIBS) $(LIBNGF_LIBS) \
$(top_srcdir)/dbus-gmain/libdbus-gmain.la
endif

if WANT_RUNLEVEL
Expand All @@ -112,8 +113,9 @@ processwd_la_SOURCES = processwd.c
processwd_la_CFLAGS = $(AM_CFLAGS) $(GLIB_CFLAGS)

dbusproxy_la_SOURCES = dbusproxy.c dsme_dbus.c
dbusproxy_la_CFLAGS = $(AM_CFLAGS) $(DBUS_CFLAGS) $(DBUSGLIB_CFLAGS)
dbusproxy_la_LIBADD = $(DBUSGLIB_LIBS) -ldsme_dbus_if
dbusproxy_la_CFLAGS = $(AM_CFLAGS) $(GLIB_CFLAGS) $(DBUS_CFLAGS)
dbusproxy_la_LIBADD = $(DBUSGLIB_LIBS) -ldsme_dbus_if \
$(top_srcdir)/dbus-gmain/libdbus-gmain.la

alarmtracker_la_SOURCES = alarmtracker.c
alarmtracker_la_CFLAGS = $(AM_CFLAGS) $(DBUS_CFLAGS)
Expand All @@ -128,12 +130,14 @@ emergencycalltracker_la_CFLAGS = $(AM_CFLAGS) $(DBUS_CFLAGS)

usbtracker_la_SOURCES = usbtracker.c
usbtracker_la_CFLAGS = $(AM_CFLAGS) $(GLIB_CFLAGS) $(DBUS_CFLAGS)
usbtracker_la_LIBADD = $(GLIB_LIBS) $(DBUS_LIBS)
usbtracker_la_LIBADD = $(GLIB_LIBS) $(DBUS_LIBS) \
$(top_srcdir)/dbus-gmain/libdbus-gmain.la

iphb_la_SOURCES = iphb.c
iphb_la_CFLAGS = $(AM_CFLAGS) $(GLIB_CFLAGS) $(DBUS_CFLAGS) $(MCE_DEV_CFLAGS)
iphb_la_CPPFLAGS = $(AM_CPPFLAGS)
iphb_la_LIBADD = $(GLIB_LIBS) $(DBUS_LIBS)
iphb_la_LIBADD = $(GLIB_LIBS) $(DBUS_LIBS) \
$(top_srcdir)/dbus-gmain/libdbus-gmain.la

thermalflagger_la_SOURCES = thermalflagger.c

Expand Down Expand Up @@ -185,7 +189,8 @@ endif
if WANT_VIBRA_FEEDBACK
shutdownfeedback_la_SOURCES = shutdownfeedback.c vibrafeedback.c vibrafeedback.h
shutdownfeedback_la_CFLAGS = $(AM_CFLAGS) $(GLIB_CFLAGS) $(DBUS_CFLAGS) $(LIBNGF_CFLAGS)
shutdownfeedback_la_LIBADD = $(GLIB_LIBS) $(LIBNGF_LIBS)
shutdownfeedback_la_LIBADD = $(GLIB_LIBS) $(LIBNGF_LIBS) \
$(top_srcdir)/dbus-gmain/libdbus-gmain.la
endif

if WANT_WLAN_LOADER
Expand Down
6 changes: 2 additions & 4 deletions modules/dsme_dbus.c
Expand Up @@ -39,10 +39,8 @@
#include "../dsme/dsme-server.h"
#include <dsme/state.h>

#include <glib.h>
#include <dbus/dbus.h>
#include <dbus/dbus-glib.h>
#include <dbus/dbus-glib-lowlevel.h>
#include <dbus-gmain/dbus-gmain.h>

#include <stdlib.h>
#include <string.h>
Expand Down Expand Up @@ -1360,7 +1358,7 @@ manager_connect(DsmeDbusManager *self)
dbus_connection_set_exit_on_disconnect(con, FALSE);

/* Attach to glib mainloop */
dbus_connection_setup_with_g_main(con, 0);
dbus_gmain_set_up_connection(con, 0);

/* Manager owns the connection */
self->mr_connection = con, con = 0;
Expand Down
5 changes: 2 additions & 3 deletions modules/iphb.c
Expand Up @@ -62,8 +62,7 @@
#include <linux/rtc.h>
#include <limits.h>
#include <dbus/dbus.h>
#include <dbus/dbus-glib.h>
#include <dbus/dbus-glib-lowlevel.h>
#include <dbus-gmain/dbus-gmain.h>
#include <mce/dbus-names.h>

#include "../include/android/android_alarm.h"
Expand Down Expand Up @@ -3017,7 +3016,7 @@ static void systembus_connect(void)
goto cleanup;
}

dbus_connection_setup_with_g_main(systembus, 0);
dbus_gmain_set_up_connection(systembus, 0);

xmce_handle_dbus_connect();

Expand Down
5 changes: 2 additions & 3 deletions modules/usbtracker.c
Expand Up @@ -49,8 +49,7 @@

#include <string.h>
#include <dbus/dbus.h>
#include <dbus/dbus-glib.h>
#include <dbus/dbus-glib-lowlevel.h>
#include <dbus-gmain/dbus-gmain.h>

/** Prefix string used for logging from this module */
#define PFIX "usbtracker: "
Expand Down Expand Up @@ -673,7 +672,7 @@ systembus_connect(void)
goto cleanup;
}

dbus_connection_setup_with_g_main(systembus, 0);
dbus_gmain_set_up_connection(systembus, 0);

xusbmoded_init_tracking();

Expand Down
4 changes: 2 additions & 2 deletions modules/vibrafeedback.c
Expand Up @@ -38,7 +38,7 @@

#include <glib.h>
#include <dbus/dbus.h>
#include <dbus/dbus-glib-lowlevel.h>
#include <dbus-gmain/dbus-gmain.h>

#include "vibrafeedback.h"

Expand Down Expand Up @@ -148,7 +148,7 @@ void dsme_ini_vibrafeedback(void) {
err.name, err.message);
goto cleanup;
}
dbus_connection_setup_with_g_main(dbus_connection, NULL);
dbus_gmain_set_up_connection(dbus_connection, NULL);
cleanup:
dbus_error_free(&err);
}
Expand Down
3 changes: 1 addition & 2 deletions rpm/dsme.spec
Expand Up @@ -14,8 +14,7 @@ Requires(preun): systemd
Requires(post): systemd
Requires(postun): systemd
BuildRequires: pkgconfig(glib-2.0) >= 2.32.0
BuildRequires: pkgconfig(dbus-1)
BuildRequires: pkgconfig(dbus-glib-1)
BuildRequires: pkgconfig(dbus-1) >= 1.8
BuildRequires: pkgconfig(libiphb) >= 1.2.0
BuildRequires: pkgconfig(dsme) >= 0.66.0
BuildRequires: pkgconfig(libsystemd)
Expand Down

0 comments on commit b0ef974

Please sign in to comment.