1. 28 Oct, 2020 3 commits
  2. 18 Sep, 2020 2 commits
    • chriadam's avatar
      Merge branch 'jb51156' into 'master' · 61c4067a
      chriadam authored
      [tracker] Disable metadata writes from MTP to tracker. Fixes JB#51156
      
      See merge request !36
      61c4067a
    • Andrew Branson's avatar
      [tracker] Disable metadata writes from MTP to tracker. Fixes JB#51156 · 2636c4f3
      Andrew Branson authored
      When files are transferred onto the device via MTP, clients can optionally
      supply metadata for those files. This data is written directly to
      Tracker's database, creating entries that would normally be created
      by tracker-miner-fs and tracker-extract. There is code intended to tell
      Tracker not to index the new files, but it has never been enabled in
      Sailfish, it if it ever was.
      
      With the new Tracker upgrade to 2.3.4, this behaviour has caused problems:
       - There are several errors and inconsistencies with tracker in the
       supplied data and how it is stored. This code has been unmaintained for
       several years.
       - Tracker tries to write its own data, but doesn't recognize the
       MTP sourced data because it intentionally ignores anything it's not
       the source for. This causes uniqueness errors in the backend which breaks
       indexing and further updates.
      
      This commit disables the storage of metadata by MTP, but does not remove
      the code. Tracker data is still read and made available to clients. This
      leaves a lot of dead code that should be cleaned up at some point once
      we're sure this is the way to go.
      Signed-off-by: default avatarAndrew Branson <andrew.branson@jolla.com>
      2636c4f3
  3. 14 Sep, 2020 1 commit
  4. 13 Sep, 2020 1 commit
  5. 24 Aug, 2020 2 commits
  6. 20 Aug, 2020 4 commits
  7. 18 Aug, 2020 2 commits
  8. 07 Aug, 2020 1 commit
    • dandreev's avatar
      [buteo-mtp] Fix unable of copy big files to SD card over MTP. Fixes JB#50733. · a0603330
      dandreev authored
      The problem is unable to copy big file (more 300 Mb) from host PC
      to SD card over MTP. At Linux after about 1-2 minutes from start:
      "libmtp error: Could not send object property list".
      Files appears but MD sums are not matched.
      At Windows on laptop: after about 1-2 minutes the copy progress
      bar disappears without any notification.
      
      It seems that ftruncate (called
      from fsstorageplugin.cpp:1305
      ...
      if( !file.resize(size))
      ...
      for big file continues too long, because it tries to fill memory
      on SD with zeros.
      strace -r /usr/lib/mtp/mtp_service
      ...
      0.000400 ftruncate64(21, 584411895) = 0
      124.915724 close(21)                 = 0
      ...
      So PC host close connection by timeout.
      
      For resolve this issue we can use another method memory allocation.
      a0603330
  9. 06 Jul, 2020 2 commits
  10. 24 Jun, 2020 2 commits
  11. 01 Nov, 2019 1 commit
  12. 25 Oct, 2019 2 commits
  13. 21 Oct, 2019 1 commit
  14. 20 Oct, 2019 1 commit
  15. 11 Oct, 2019 1 commit
  16. 10 Oct, 2019 5 commits
  17. 26 Sep, 2019 2 commits
  18. 25 Sep, 2019 1 commit
  19. 01 Mar, 2019 2 commits
  20. 28 Feb, 2019 3 commits
    • spiiroin's avatar
      [buteo-mtp] Use dconf setting for selecting symlink policy. JB#44457 · 0a578048
      spiiroin authored
      Using dconf for configuring behavioral changes is preferred over
      environment.
      
      Users can change the symlink policy by setting dconf string value
      with key /desktop/sailfish/buteo-mtp/symlink_policy.
      
      When needed device specific configuration files can be used to
      select default value, and optionally lock down the selection.
      Signed-off-by: spiiroin's avatarSimo Piiroinen <simo.piiroinen@jollamobile.com>
      0a578048
    • spiiroin's avatar
      [fsstorageplugin] Implement symlink policy. JB#44457 · ee0a28cd
      spiiroin authored
      If buteo-mtp bumps upon symlinks, they are followed indiscriminately - which
      allows escaping from storage directory boundaries and/or blacklist
      configuration.
      
      While the current behavior can be considered as a feature, sometimes it might
      be desirable to limit whether and what kind of symlinks are followed.
      
      Implement symbolic link policy, controlled by environment variable
      BUTEO_MTP_SYMLINK_POLICY, which can have one of the following values:
      
      - AllowAll - symbolic links are always followed
      - DenyAll - all symbolic links are ignored
      - AllowWithinStorage - symbolic links that stay within the storage
        are followed
      
      By default "AllowAll" is selected, i.e. buteo-mtp behaves like before.
      Signed-off-by: spiiroin's avatarSimo Piiroinen <simo.piiroinen@jollamobile.com>
      ee0a28cd
    • spiiroin's avatar
      [systemd] Do not use script to launch buteo-mtp binary · f05ed729
      spiiroin authored
      The start-mtp.sh has a feature (create dummy directory for exposing parts of
      user home directory via symlinks) that makes it look like it were a) meant
      to be used for development time debugging, or b) some kind of attempt to
      provide sandboxing.
      
      While none of these features are needed in default setup, the ability to
      control buteo-mtp environment from user editable files means they can be
      activated without requiring any special prileges.
      
      Launch buteo-mtp binary directly without involving launcher script.
      
      To support things like controlling logging verbosity, add enablers for using
      environment files in root writable directories.
      
      Remove the now unused script altogether.
      Signed-off-by: spiiroin's avatarSimo Piiroinen <simo.piiroinen@jollamobile.com>
      f05ed729
  21. 27 Feb, 2019 1 commit