Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in
L
libcontacts
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • mer-core-attic
  • libcontacts
  • Merge Requests
  • !6

Merged
Opened Aug 30, 2018 by pvuorela@pvuorela
  • Report abuse
Report abuse

Fix recursive resolve

  • Overview 0
  • Commits 2
  • Changes 1

ResolveListener::addressResolved() implementations can do silly things like start resolving for something it just received information for. That ended up new request being filtered out as duplicate request but then never getting response with addressResolved.

Above case with libcommhistory / RecentContactsModel.

Model there not necessarily doing all things properly, but at least now it doesn't end up staying in not-ready state under some conditions.

@jpetrell @chriadam

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: mer-core-attic/libcontacts!6

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.