1. 04 Oct, 2017 2 commits
  2. 03 Oct, 2017 1 commit
  3. 09 May, 2017 5 commits
  4. 27 Feb, 2017 3 commits
    • chriadam's avatar
      Bump version · 5714002e
      chriadam authored
      5714002e
    • chriadam's avatar
      Merge branch 'mer1696' into 'master' · fab9a917
      chriadam authored
      [buteo-sync-plugin-carddav-tests] Add a tool to allow easily creating automated system test scripts. Contributes to MER#1696
      
      This commit adds a test tool which provides functionality which allows
      the creation of automated system test scripts.
      
      Contributes to MER#1696
      
      See merge request !9
      fab9a917
    • chriadam's avatar
      [buteo-sync-plugin-carddav-tests] Add a tool to allow easily creating... · 9f4b4b11
      chriadam authored
      [buteo-sync-plugin-carddav-tests] Add a tool to allow easily creating automated system test scripts. Contributes to MER#1696
      
      This commit adds a test tool which provides functionality which allows
      the creation of automated system test scripts.
      
      Contributes to MER#1696
      9f4b4b11
  5. 13 Dec, 2016 2 commits
  6. 12 Dec, 2016 1 commit
  7. 09 Dec, 2016 1 commit
  8. 11 Oct, 2016 6 commits
    • chriadam's avatar
      Bump version · c87661ad
      chriadam authored
      c87661ad
    • chriadam's avatar
      Merge branch 'mer1657' into 'master' · fba842a9
      chriadam authored
      [buteo-sync-plugin-carddav] Detect non-addressbook resources. Contributes to MER#1657
      
      This commit adds a check in our handling for resources during
      addressbook information parsing, by ensuring that we require that
      a resource be an addressbook collection resource in order to be
      treated as one.  Previously, the code only checked that the
      status code associated with the resource was 200 OK, due to an
      omission of a variable check.
      
      Contributes to MER#1657
      
      See merge request !8
      fba842a9
    • chriadam's avatar
      [buteo-sync-plugin-carddav] Detect non-addressbook resources. Contributes to MER#1657 · 06e51b26
      chriadam authored
      This commit adds a check in our handling for resources during
      addressbook information parsing, by ensuring that we require that
      a resource be an addressbook collection resource in order to be
      treated as one.  Previously, the code only checked that the
      status code associated with the resource was 200 OK, due to an
      omission of a variable check.
      
      Contributes to MER#1657
      06e51b26
    • chriadam's avatar
      Merge branch 'mer1665' into 'master' · e539bc7b
      chriadam authored
      [buteo-sync-plugin-carddav] Improve delta determination logic. Contributes to JB#1665
      
      Some CardDAV servers return the status for a response outside of the
      propstat element.  Previously, the code assumed that the status would
      be contained within the propstat element, this commit ensures that
      we handle that status information.
      
      This commit also fixes a bug in the upsync-delta-determination code
      which would misreport whether the local contact had differences
      to the remote contact in most cases, resulting in either a spurious
      upsync or a missed upsync.
      
      Contributes to JB#1665
      
      See merge request !7
      e539bc7b
    • chriadam's avatar
      [buteo-sync-plugin-carddav] Improve delta determination logic. Contributes to JB#1665 · b2d19441
      chriadam authored
      Some CardDAV servers return the status for a response outside of the
      propstat element.  Previously, the code assumed that the status would
      be contained within the propstat element, this commit ensures that
      we handle that status information.
      
      This commit also fixes a bug in the upsync-delta-determination code
      which would misreport whether the local contact had differences
      to the remote contact in most cases, resulting in either a spurious
      upsync or a missed upsync.
      
      Contributes to JB#1665
      b2d19441
    • chriadam's avatar
      Merge branch 'unittests' into 'master' · faea0fce
      chriadam authored
      Add unit test framework to allow testing ReplyParser functionality
      
      This commit adds a unit test framework to allow the ReplyParser
      to be properly unit tested.  The ReplyParser is where any response
      from a remote CardDAV server is parsed and converted into valid
      values, and thus it is the most common point of failure.
      
      See merge request !6
      faea0fce
  9. 10 Oct, 2016 1 commit
    • chriadam's avatar
      Add unit test framework to allow testing ReplyParser functionality · 2dbd14fd
      chriadam authored
      This commit adds a unit test framework to allow the ReplyParser
      to be properly unit tested.  The ReplyParser is where any response
      from a remote CardDAV server is parsed and converted into valid
      values, and thus it is the most common point of failure.
      2dbd14fd
  10. 01 Apr, 2016 3 commits
  11. 09 Mar, 2016 2 commits
    • chriadam's avatar
      Bump version · d1e426df
      chriadam authored
      d1e426df
    • chriadam's avatar
      Merge branch 'migrateguids' into 'master' · d17f55b0
      chriadam authored
      [buteo-sync-plugin-carddav] Migrate existing guids to new form. Contributes to MER#1535
      
      This commit ensures that users who have previously synced their
      carddav account will have their sync state data migrated to use the
      new guid form appropriately, preventing lost updates.
      
      Contributes to MER#1535
      
      See merge request !4
      d17f55b0
  12. 07 Mar, 2016 1 commit
  13. 04 Mar, 2016 3 commits
    • chriadam's avatar
      Bump version · c1e95491
      chriadam authored
      c1e95491
    • chriadam's avatar
      Merge branch 'duplicateuids' into 'master' · d88f95fe
      chriadam authored
      [buteo-sync-plugin-carddav] Support non-unique UIDs. Contributes to MER#1535
      
      RFC6352 only requires that the UID be unique within a single collection
      (addressbook).  This commit makes our plugin mangle the UID into a
      GUID which includes the addressbookUrl information, to ensure that
      we support non-unique UIDs via unique GUIDs.
      
      It also does duplication detection to determine whether the duplicated
      UID is due to the same contact existing in multiple addressbooks,
      or due to two different contacts (who happen to have the same UID)
      being in different addressbooks.  Detecting duplicates requires some
      heuristic detection of significant differences between contacts.
      
      Contributes to MER#1535
      
      See merge request !3
      d88f95fe
    • chriadam's avatar
      [buteo-sync-plugin-carddav] Support non-unique UIDs. Contributes to MER#1535 · c23a328c
      chriadam authored
      RFC6352 only requires that the UID be unique within a single collection
      (addressbook).  This commit makes our plugin mangle the UID into a
      GUID which includes the addressbookUrl information, to ensure that
      we support non-unique UIDs via unique GUIDs.
      
      It also does duplication detection to determine whether the duplicated
      UID is due to the same contact existing in multiple addressbooks,
      or due to two different contacts (who happen to have the same UID)
      being in different addressbooks.  Detecting duplicates requires some
      heuristic detection of significant differences between contacts.
      
      Contributes to MER#1535
      c23a328c
  14. 30 Oct, 2015 4 commits
    • chriadam's avatar
      Bump version · 275100a6
      chriadam authored
      275100a6
    • chriadam's avatar
      Merge branch 'bugfixes' into 'master' · 0884f44a
      chriadam authored
      Improve addressbook-home-set parsing and vCard handling
      
      
      
      See merge request !2
      0884f44a
    • chriadam's avatar
      [buteo-sync-plugin-carddav] Improve vCard FN parsing. Contributes to MER#1379 · b4947820
      chriadam authored
      This commit ensures that we decompose FN values into a structured name
      detail before storing the resultant contact into our backend.
      This allows us to correctly aggregate contacts for which the server
      provides an FN but no N property in the vCard.
      
      Contributes to MER#1379
      b4947820
    • chriadam's avatar
      [buteo-sync-plugin-carddav] Relax our comparison strictness during delta... · 430ad0d5
      chriadam authored
      [buteo-sync-plugin-carddav] Relax our comparison strictness during delta detection. Contributes to MER#1379
      
      This commit ensures that we disregard X-GENDER properties and also
      ADR property TYPE parameters during delta detection.
      
      The X-GENDER property is required by our backend and therefore will
      always exist locally even if we don't upsync it, thus should not be
      considered in the delta.
      The ADR property's TYPE parameter is also handled specially by our
      backend and can be removed from the delta comparison.
      
      Contributes to MER#1379
      430ad0d5
  15. 29 Oct, 2015 1 commit
    • chriadam's avatar
      [buteo-sync-plugin-carddav] Ignore addressbook-home-set response to... · 0bd348a8
      chriadam authored
      [buteo-sync-plugin-carddav] Ignore addressbook-home-set response to addressbook information request. Contributes to MER#1304
      
      This commit ensures that we ignore any addressbook-home-set element
      in the response to the addressbook information request, as some
      implementations will return both addressbook-home-set and addressbook
      collection information in response to the addressbook information
      request.
      
      Contributes to MER#1304
      0bd348a8
  16. 14 Oct, 2015 4 commits
    • chriadam's avatar
      Bump version · 1ee72608
      chriadam authored
      1ee72608
    • chriadam's avatar
      Merge pull request #21 from nemomobile/multipropstat · 1f6d29bb
      chriadam authored
      [buteo-sync-plugin-carddav] Improve addressbook-set parsing. Contributes to MER#1304
      1f6d29bb
    • chriadam's avatar
      [buteo-sync-plugin-carddav] Proceed if MethodNotAllowed encountered on upsync.... · 97b0e80c
      chriadam authored
      [buteo-sync-plugin-carddav] Proceed if MethodNotAllowed encountered on upsync.  Contributes to MER#1304
      
      This commit ensures that we continue the sync even in the case where
      the server returns a HTTP 405 MethodNotAllowed error on upsync.
      In that case, the server has a Read-Only (or Modify-Only) policy
      for the given collection.  We should not fail the entire sync,
      but some conflict resolution will occur on next sync.
      
      Contributes to MER#1304
      97b0e80c
    • chriadam's avatar
      Improve vCard generation code · 9c7d183e
      chriadam authored
      This commit improves the vCard generation by:
      - ensuring that FN field is present in the final result
      - removing X-GENDER if the value is "Unspecified"
      9c7d183e